Page MenuHomePhabricator

[native] fix rendering of edit thread name settings button
ClosedPublic

Authored by ginsu on Apr 24 2023, 11:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 8:38 PM
Unknown Object (File)
Sat, Nov 9, 8:38 PM
Unknown Object (File)
Sat, Nov 9, 8:35 PM
Unknown Object (File)
Tue, Nov 5, 10:07 PM
Unknown Object (File)
Tue, Nov 5, 2:10 AM
Unknown Object (File)
Mon, Nov 4, 3:22 AM
Unknown Object (File)
Oct 3 2024, 2:20 AM
Unknown Object (File)
Sep 14 2024, 8:56 PM
Subscribers

Details

Summary

As I was testing the loaders in Thread Settings for ENG-3741 I came across an issue where if the user navigated away from thread settings and back to it, then the button would not render while the new name was being saved. This was happening because nameEditValue was not being set since we navigated away from the screen so we were only just rendering SaveSettingButton which in turn render nothing since canChangeSettings is set to false while the name is being set. To fix this I created a separate function that just handles the rendering of the button and used that function within renderContent and now an ActivityIndicator will always render while the setting is being saved

A follow up diff for fixing the description will be up shortly

Test Plan

Please see the demo videos below to see the changes I made:

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Apr 24 2023, 12:35 PM