[native] improve factoring out redundant logic for saving an image thread avatar
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 10:41 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM6309c77470c9: [native] improve factoring out redundant logic for saving an image thread avatar

Summary

This diff factors out the update image avatar logic into its own function. This logic is directly shared and used by both the edit image avatar through gallery and camera. So I factored this logic out here in anticipation of the introduction of the edit thread avatar camera modal which is introduced in the next diff

Depends on D7644

Test Plan

flow and setting an image thread avatar still works with the expected behavior

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2023, 10:41 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 10:41 PM

ginsu edited the summary of this revision. (Show Details)Apr 26 2023, 10:41 PM

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7644: [native] move navigate to emoji thread avatar creation function to be within edit thread avatar.

ginsu added a child revision: D7646: [native] introduce thread avatar camera modal.Apr 26 2023, 10:44 PM

Harbormaster completed remote builds in B18833: Diff 25801.Apr 26 2023, 10:58 PM

ginsu requested review of this revision.Apr 26 2023, 10:58 PM

Same feedback as in D7628:

It would be good to explain the reason for the changes here. Are these changes being made because you're going to reuse the factored-out code in a later diff in the stack, so it makes sense to factor out the shared logic here?

This revision is now accepted and ready to land.Apr 27 2023, 10:27 AM

rebase

ginsu edited the summary of this revision. (Show Details)Apr 28 2023, 1:18 PM

Harbormaster completed remote builds in B18929: Diff 25928.Apr 28 2023, 1:30 PM

rebase before landing

Harbormaster completed remote builds in B18946: Diff 25945.Apr 30 2023, 10:08 PM

Closed by commit rCOMM6309c77470c9: [native] improve factoring out redundant logic for saving an image thread avatar (authored by ginsu). · Explain WhyApr 30 2023, 10:17 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM6309c77470c9: [native] improve factoring out redundant logic for saving an image thread avatar.