Page MenuHomePhabricator
Differential D7646

[native] introduce thread avatar camera modal
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 10:43 PM.
Tags
None
Referenced Files
F3644932: D7646.id.diff
Sat, Jan 4, 7:22 PM
Unknown Object (File)
Mon, Dec 16, 12:25 AM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:25 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM6f746f5b1126: [native] introduce thread avatar camera modal
Summary

Introduce thread avatar camera modal

Depends on D7645

Test Plan

Able to set an image thread avatar through the camera roll. Tested other cases like closing out of the camera modal and everything works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2023, 10:43 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 10:43 PM
ginsu edited the summary of this revision. (Show Details)Apr 26 2023, 10:44 PM
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7645: [native] improve factoring out redundant logic for saving an image thread avatar.
ginsu mentioned this in D7550: [native] introduce naive thread avatar camera modal.Apr 26 2023, 10:48 PM
Harbormaster completed remote builds in B18834: Diff 25802.Apr 26 2023, 11:00 PM
ginsu requested review of this revision.Apr 26 2023, 11:00 PM
ashoat requested changes to this revision.Apr 27 2023, 10:29 AM
ashoat added inline comments.
native/media/thread-avatar-camera-modal.react.js
25 ↗(On Diff #25802)

We shouldn't need this alias. Let's pass in sendPhoto directly to CameraModal. I shared more detailed feedback about how to do this in D7624

This revision now requires changes to proceed.Apr 27 2023, 10:29 AM
ginsu updated this revision to Diff 25941.Apr 30 2023, 10:00 AM

address comments

ginsu added inline comments.Apr 30 2023, 10:01 AM
native/media/thread-avatar-camera-modal.react.js
32 ↗(On Diff #25941)

Kept the callback because now we should pass in threadID to updateImageThreadAvatar

Harbormaster completed remote builds in B18942: Diff 25941.Apr 30 2023, 10:17 AM
ashoat accepted this revision.Apr 30 2023, 1:50 PM
This revision is now accepted and ready to land.Apr 30 2023, 1:50 PM
ginsu updated this revision to Diff 25946.Apr 30 2023, 9:53 PM

rebase before landing

Harbormaster completed remote builds in B18947: Diff 25946.Apr 30 2023, 10:10 PM
Closed by commit rCOMM6f746f5b1126: [native] introduce thread avatar camera modal (authored by ginsu). · Explain WhyApr 30 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6f746f5b1126: [native] introduce thread avatar camera modal.

Revision Contents
Changeset List

Diff 25953

View Options

native/avatars/edit-thread-avatar-provider.react.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/media/thread-avatar-camera-modal.react.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...