[native] introduce naive thread avatar camera modal
AbandonedPublic
Actions

Authored by ginsu on Apr 19 2023, 8:58 PM.

Details

Reviewers

ashoat
atul

Summary

This diff handles introducing editing a thread avatar thorugh a phone camera. A ton of copy/paste here... will be working on cleaning all this up shortly

Depends on D7549

Test Plan

Built the app on my phone and could edit a thread avatar through my camera. Going back from the thread avatar camera modal also behaves as expected with the behavoir being that it navigates back to thread settings

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 19 2023, 8:58 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 8:58 PM

ginsu published this revision for review.Apr 19 2023, 8:59 PM

ginsu added reviewers: ashoat, atul.

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7549: [native] introduce naive user avatar camera modal.

Harbormaster completed remote builds in B18575: Diff 25451.Apr 19 2023, 9:16 PM

ashoat requested changes to this revision.Apr 20 2023, 9:56 AM

ashoat added inline comments.

native/avatars/edit-thread-avatar.react.js
35	I don't think this works. You have two separate invocations of `useSelectFromCameraAndUpdateThreadAvatar` – one here, and one in `ThreadAvatarCameraModal`. Each of these invocations leads to distinct React state being created (`processingOrUploadInProgress`), and the two versions of this state are not synced