[native] introduce naive user avatar camera modal
AbandonedPublic
Actions

Authored by ginsu on Apr 20 2023, 2:08 AM.

Details

Reviewers

ashoat
atul

Summary

Introduce user avatar camera modal. Will introduce thread avatar camera modal momentailry. Sorry that this diff is pretty large but hopefully Phab highlights all the copy/paste

Depends on D7548

Test Plan

I was able to use my camera to take a photo and the photo i snapped was set as my avatar after hitting "send" in the camera modal. Also tested going back, and when I hit the "X" button it just goes back to the profile screen

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 20 2023, 2:08 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 20 2023, 2:08 AM

ginsu added inline comments.Apr 20 2023, 2:12 AM

native/avatars/avatar-hooks.js
428 ↗	(On Diff #25445)	To build `useSelectFromCameraAndUpdateUserAvatar` I copied and pasted the code from `useSelectFromCameraAndUpdateUserAvatar`. However, the big difference between the two is that instead of getting the `selection` from within the hook using something like `selectFromGallery`, we can instead just pass `selection` as a parameter when `UserAvatarCameraModal` uses this hook
570–574 ↗	(On Diff #25445)	Tested what this looks like on Android, and got the following:

ginsu attached a referenced file: F497752: Screenshot 2023-04-19 at 10.00.10 PM.png. (Show Details)Apr 20 2023, 2:13 AM

ginsu retitled this revision from [native] introduce user avatar camera modal to [native] introduce naive user avatar camera modal.

ginsu edited the summary of this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu published this revision for review.Apr 20 2023, 2:15 AM

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7548: [native] change type for useProcessSelectedMedia from MediaLibrarySelection to NativeMediaSelection.

Harbormaster failed remote builds in B18571: Diff 25445!Apr 20 2023, 2:23 AM

update order of route name

Harbormaster failed remote builds in B18572: Diff 25447!Apr 20 2023, 2:39 AM

simplify return

ginsu added a child revision: D7550: [native] introduce naive thread avatar camera modal.Apr 20 2023, 3:59 AM

Harbormaster completed remote builds in B18574: Diff 25450.Apr 20 2023, 4:05 AM

ashoat requested changes to this revision.Apr 20 2023, 4:58 PM

ashoat added inline comments.

native/avatars/edit-user-avatar.react.js
42	I don't think this works. You have two separate invocations of `useSelectFromCameraAndUpdateUserAvatar` – one here, and one in `UserAvatarCameraModal`. Each of these invocations leads to distinct React state being created (`processingOrUploadInProgress`), and the two versions of this state are not synced

This revision now requires changes to proceed.Apr 20 2023, 4:58 PM

ginsu added inline comments.Apr 20 2023, 5:36 PM

native/avatars/edit-user-avatar.react.js
42	Okay yea that makes sense, didn't realize that would be the case, but really good to know. So sounds like we need to introduce a context here to keep the state in sync