Introduce user avatar camera modal. Will introduce thread avatar camera modal momentailry. Sorry that this diff is pretty large but hopefully Phab highlights all the copy/paste
Depends on D7548
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/avatars/avatar-hooks.js | ||
|---|---|---|
| 428 ↗ | (On Diff #25445) | To build useSelectFromCameraAndUpdateUserAvatar I copied and pasted the code from useSelectFromCameraAndUpdateUserAvatar. However, the big difference between the two is that instead of getting the selection from within the hook using something like selectFromGallery, we can instead just pass selection as a parameter when UserAvatarCameraModal uses this hook |
| 570–574 ↗ | (On Diff #25445) | Tested what this looks like on Android, and got the following:  |
| native/avatars/edit-user-avatar.react.js | ||
|---|---|---|
| 42 | I don't think this works. You have two separate invocations of useSelectFromCameraAndUpdateUserAvatar – one here, and one in UserAvatarCameraModal. Each of these invocations leads to distinct React state being created (processingOrUploadInProgress), and the two versions of this state are not synced | |
| native/avatars/edit-user-avatar.react.js | ||
|---|---|---|
| 42 | Okay yea that makes sense, didn't realize that would be the case, but really good to know. So sounds like we need to introduce a context here to keep the state in sync | |