Page MenuHomePhabricator

[native] register user on native (C++ changes)
ClosedPublic

Authored by varun on May 1 2023, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 7:18 PM
Unknown Object (File)
Wed, Feb 26, 7:18 PM
Unknown Object (File)
Wed, Feb 26, 7:18 PM
Unknown Object (File)
Wed, Feb 26, 7:18 PM
Unknown Object (File)
Wed, Feb 26, 7:17 PM
Unknown Object (File)
Wed, Feb 26, 7:02 PM
Unknown Object (File)
Tue, Feb 18, 8:11 PM
Unknown Object (File)
Feb 17 2025, 3:50 PM
Subscribers

Details

Summary

add registerUser function to CommCoreModule

Test Plan

successfully registered a new user from js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.May 1 2023, 7:45 AM

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

rename identity -> content

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

we glob the files ("MODULE_ROOT_NATIVE_CODE") so no CMake changes needed

native/cpp/CommonCpp/NativeModules/JSIRust.cpp
6 ↗(On Diff #26025)

You should #include all of the stuff you use, so eg. #include <string> for this

Seems good to me (assuming it passes CI)

This revision is now accepted and ready to land.May 3 2023, 1:29 PM