For new clients (>215), we return CreateUpdatesResult instead of ClientAvatar.
Context can be found:
ENG-3808 : updateUserAvatar should create UPDATE_USER and UPDATE_CURRENT_USER updates
Details
Details
Log CreateUpdatesResult on keyserver and ensure that it's as expected:
Will be tested implicitly by subsequent diff which includes necessary change on client (w/ codeVersion bumped to 215 for testing)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D7699 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 195 ↗ | (On Diff #25974) | It's always better to return an object, so that it will be easier to change this in the future if we need to |
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 632–634 ↗ | (On Diff #25980) | We usually define these alongside the Result and Payload types (if any) – could you move this to lib/types/avatar-types.js? |
Comment Actions
Re-opening to address flow issues...
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 632–634 ↗ | (On Diff #25980) | Yup, will do |
Comment Actions
Okay so when I ran flow in keyserver, there were no issues. Then I ran it again AFTER yarn cleaninstall && killall flow and it gave me the three issues... so I guess got in some bad state? Hopefully a one-off issue