Page MenuHomePhabricator
Differential D7708

[native] Don't crash if TagInput is unmounted before error received
ClosedPublic
Actions

Authored by ashoat on May 3 2023, 1:29 PM.
Tags
None
Referenced Files
F3177498: D7708.diff
Thu, Nov 7, 11:33 PM
Unknown Object (File)
Mon, Oct 28, 10:23 AM
Unknown Object (File)
Mon, Oct 28, 10:23 AM
Unknown Object (File)
Mon, Oct 28, 10:23 AM
Unknown Object (File)
Mon, Oct 28, 10:21 AM
Unknown Object (File)
Wed, Oct 23, 8:20 PM
Unknown Object (File)
Thu, Oct 10, 11:59 AM
Unknown Object (File)
Oct 2 2024, 2:41 PM
View All 56 Files
Subscribers
None

Details

Reviewers
atul
ginsu
tomek
Commits
rCOMM4bbb90307487: [native] Don't crash if TagInput is unmounted before error received
Summary

I saw a bug where if I added a user, then left the screen before the server response came in, BUT the server response was an error, I would get a crash with "tagInput should be set".

The issue is that we have an invariant that assumes the TagInput is mounted when the error comes in. But if the user leaves the screen before the error, then the TagInput might be unmounted before the error.

Test Plan

Confirm there are no remaining instances of tagInput should be set in the codebase

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/crash
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
chat/
3 lines
settings/
4 lines
profile/
3 lines

Diff 26046

View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

native/profile/relationship-list.react.js

Loading...