[lib] Fix crash when logged out with sidebar open
ClosedPublic
Actions

Authored by ashoat on May 4 2023, 9:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 12, 2:52 PM

	Unknown Object (File)
	Mon, Jun 10, 5:00 PM

	Unknown Object (File)
	Tue, Jun 4, 6:12 PM

	Unknown Object (File)
	May 16 2024, 8:42 AM

	Unknown Object (File)
	Apr 5 2024, 3:23 AM

	Unknown Object (File)
	Apr 5 2024, 3:23 AM

	Unknown Object (File)
	Apr 5 2024, 3:22 AM

	Unknown Object (File)
	Apr 5 2024, 3:18 AM

View All 30 Files

Subscribers

None

Details

Reviewers

michal
tomek
atul

Commits

rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open

Summary

See more details about the crash in ENG-3837. The inline code comment also provides more context on what was happening.

Test Plan

I reproduced the crash described in the Linear issue, and then confirmed it no longer occurs with this change

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/crash

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 4 2023, 9:59 AM

Harbormaster completed remote builds in B19049: Diff 26081.May 4 2023, 10:17 AM

ashoat requested review of this revision.May 4 2023, 10:17 AM

atul accepted this revision.May 4 2023, 10:22 AM

This revision is now accepted and ready to land.May 4 2023, 10:22 AM

Closed by commit rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open (authored by ashoat). · Explain WhyMay 4 2023, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

11 lines

Diff 26081

View Options

lib/shared/mention-utils.js

[lib] Fix crash when logged out with sidebar openClosedPublicActions