Page MenuHomePhabricator
Differential D7719

[lib] Fix crash when logged out with sidebar open
ClosedPublic
Actions

Authored by ashoat on May 4 2023, 9:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 2 2025, 12:28 AM
Unknown Object (File)
Mar 2 2025, 12:28 AM
Unknown Object (File)
Mar 2 2025, 12:19 AM
Unknown Object (File)
Mar 1 2025, 7:48 AM
Unknown Object (File)
Feb 17 2025, 3:50 PM
Unknown Object (File)
Feb 16 2025, 2:38 PM
Unknown Object (File)
Feb 13 2025, 11:42 AM
Unknown Object (File)
Jan 25 2025, 7:23 AM
View All 80 Files
Subscribers
None

Details

Reviewers
michal
tomek
atul
Commits
rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open
Summary

See more details about the crash in ENG-3837. The inline code comment also provides more context on what was happening.

Test Plan

I reproduced the crash described in the Linear issue, and then confirmed it no longer occurs with this change

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
11 lines

Diff 26084

View Options

lib/shared/mention-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines