[native] Add copy for ConnectEthereum screen
ClosedPublic
Actions

Authored by ashoat on May 10 2023, 3:57 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM557c8113380f: [native] Add copy for ConnectEthereum screen

Summary

See screenshots. Positioning the Ethereum logo and getting the button style right will be handled in subsequent diffs.

Test Plan

nerd mode	cool mode

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/registration

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 10 2023, 3:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 10 2023, 3:57 AM

ashoat edited the test plan for this revision. (Show Details)May 10 2023, 3:58 AM

Harbormaster completed remote builds in B19233: Diff 26333.May 10 2023, 4:15 AM

ashoat requested review of this revision.May 10 2023, 4:15 AM

(Personally think it might look better if the Ethereum logo was above the text)

This revision is now accepted and ready to land.May 10 2023, 5:16 AM

on the app -> in the app

This revision was landed with ongoing or failed builds.May 10 2023, 5:29 AM

Closed by commit rCOMM557c8113380f: [native] Add copy for ConnectEthereum screen (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM557c8113380f: [native] Add copy for ConnectEthereum screen.

Harbormaster completed remote builds in B19236: Diff 26336.May 10 2023, 5:46 AM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-ethereum.react.js

70 lines

Diff 26336

View Options

native/account/registration/connect-ethereum.react.js

[native] Add copy for ConnectEthereum screenClosedPublicActions