Page MenuHomePhabricator

[native] Avoid transition delay during upload
ClosedPublic

Authored by bartek on May 10 2023, 7:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 2:43 AM
Unknown Object (File)
Sat, Mar 2, 7:42 PM
Unknown Object (File)
Feb 12 2024, 9:36 PM
Unknown Object (File)
Feb 10 2024, 2:46 PM
Unknown Object (File)
Feb 10 2024, 11:24 AM
Unknown Object (File)
Feb 10 2024, 11:24 AM
Unknown Object (File)
Feb 10 2024, 11:24 AM
Unknown Object (File)
Feb 10 2024, 10:37 AM
Subscribers

Details

Summary

Fixes ENG-3615. I discovered that the problem was in our departing vs current source logic in multimedia.react.js. Both sources caused onLoad to be triggered. Because departing source is usually local URI, it was loaded much faster, triggered onLoad which removed itself way before the current source was actually loaded.

Added boolean to indicate that onLoad should not be triggered for departing source.

Depends on D7765

Test Plan

Artifically disabled cache and delayed decryption in encrypted-image.react.js and sent an encrypted photo. The local image was displayed instead of a spinner until decryption finishes. After leaving and re-entering the thread, the spinner was displayed until the image was decrypted.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable