Page MenuHomePhabricator

[native] Add base64 decode to CommUtilsModule
ClosedPublic

Authored by bartek on May 9 2023, 6:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 7:20 AM
Unknown Object (File)
Thu, Mar 28, 9:02 PM
Unknown Object (File)
Thu, Mar 28, 9:02 PM
Unknown Object (File)
Thu, Mar 28, 9:02 PM
Unknown Object (File)
Thu, Mar 28, 9:02 PM
Unknown Object (File)
Thu, Mar 28, 9:01 PM
Unknown Object (File)
Thu, Mar 28, 8:53 PM
Unknown Object (File)
Mar 3 2024, 4:23 AM
Subscribers

Details

Summary

This adds JSI bindings for D7758 to the native CommUtilsModule.

Depends on D7758.

Test Plan

Encoded and decoded a Uint8Array into base64, using commCoreModule.base64{Encode,Decode}buffer() and console-log.

Used three different length of Uint8Arrays to test all padding values, e.g.:

new Uint8Array([1,2,3,4,5,6]);  // AQIDBAUG
new Uint8Array([1,2,3,4,5,6,7]); // AQIDBAUGBw==
new Uint8Array([1,2,3,4,5,6,7,8]); // AQIDBAUGBwg=

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.May 9 2023, 8:15 AM

Could you make sure in Test Plan that you tested decoding strings with each length of padding at the end (none, =, and ==)?

This revision is now accepted and ready to land.May 15 2023, 2:21 AM