Page MenuHomePhabricator
Differential D7810

[native] login wallet user (C++)
ClosedPublic
Actions

Authored by varun on May 15 2023, 7:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 2:30 PM
Unknown Object (File)
Fri, May 3, 2:56 PM
Unknown Object (File)
Wed, May 1, 3:56 PM
Unknown Object (File)
Wed, May 1, 3:43 PM
Unknown Object (File)
Apr 16 2024, 3:22 AM
Unknown Object (File)
Apr 16 2024, 12:46 AM
Unknown Object (File)
Apr 15 2024, 9:18 PM
Unknown Object (File)
Apr 15 2024, 12:12 AM
View All 55 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
Commits
rCOMMa79d72de974f: [native] login wallet user (C++)
Summary

call the new rust client method from C++

Depends on D7809

Test Plan

was able to successfully call the identity service RPC from JS. this will be tested more rigorously when we actually change the login callsites on native

Diff Detail

Repository
rCOMM Comm
Branch
native (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 15 2023, 7:54 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMay 15 2023, 7:54 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 15 2023, 8:12 AM
Harbormaster failed remote builds in B19340: Diff 26465!
varun updated this revision to Diff 27316.May 31 2023, 12:08 PM

add socialProof

Harbormaster completed remote builds in B19931: Diff 27316.May 31 2023, 12:27 PM
varun requested review of this revision.May 31 2023, 12:27 PM
ashoat accepted this revision.May 31 2023, 12:37 PM
This revision is now accepted and ready to land.May 31 2023, 12:37 PM
Closed by commit rCOMMa79d72de974f: [native] login wallet user (C++) (authored by varun). · Explain WhyMay 31 2023, 12:53 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa79d72de974f: [native] login wallet user (C++).

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
13 lines
50 lines
_generated/
schema/
13 lines

Diff 27316

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...