Page MenuHomePhabricator

[native] Introduce RegistrationContainer to handle SafeAreaView
ClosedPublic

Authored by ashoat on May 16 2023, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 5:20 AM
Unknown Object (File)
Mon, Mar 10, 4:21 PM
Unknown Object (File)
Mon, Mar 10, 4:21 PM
Unknown Object (File)
Mon, Mar 10, 4:11 PM
Unknown Object (File)
Mon, Mar 10, 3:48 PM
Unknown Object (File)
Mon, Mar 10, 3:47 PM
Unknown Object (File)
Tue, Feb 25, 9:16 AM
Unknown Object (File)
Feb 17 2025, 1:02 PM
Subscribers

Details

Summary

Before this diff, we wrapped all registration screens with a SafeAreaView in RegistrationNavigator.

However, this meant that the SIWEPanel background had a sharp cutoff at the SafeAreaView bounds.

In order to allow the SIWEPanel to appear over the SafeAreaView, this diff moves responsibility for rendering SafeAreaView to the individual screens. This is achieved with a new RegistrationContainer component.

Depends on D7844

Test Plan
beforeafter
Screenshot 2023-05-16 at 3.19.49 PM.png (1×565 px, 222 KB)
Screenshot 2023-05-16 at 3.19.40 PM.png (1×565 px, 226 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable