[native] Add loading spinner to RegistrationButton loading variant
ClosedPublic
Actions

Authored by ashoat on May 16 2023, 12:39 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM1710139fc7b7: [native] Add loading spinner to RegistrationButton loading variant

Summary

ConnectEthereum is the first place we're actually using the loading variant; before this point, I hadn't really implemented it.

This diff implements the loading variant with a loading spinner that is absolutely-positioned over the normal content.

The reason I took that approach is to avoid issues with the height changing. This way I don't have to worry about calculating the height of the text, or forcing the height of the text to be something specific.

Depends on D7845

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 16 2023, 12:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 16 2023, 12:39 PM

ashoat edited the test plan for this revision. (Show Details)May 16 2023, 12:40 PM

Harbormaster completed remote builds in B19420: Diff 26565.May 16 2023, 12:59 PM

ashoat requested review of this revision.May 16 2023, 12:59 PM

atul accepted this revision.May 16 2023, 3:13 PM

This revision is now accepted and ready to land.May 16 2023, 3:13 PM

Closed by commit rCOMM1710139fc7b7: [native] Add loading spinner to RegistrationButton loading variant (authored by ashoat). · Explain WhyMay 17 2023, 5:27 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1710139fc7b7: [native] Add loading spinner to RegistrationButton loading variant.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-button.react.js

36 lines

Diff 26618

View Options

native/account/registration/registration-button.react.js

[native] Add loading spinner to RegistrationButton loading variantClosedPublicActions