[web] Convert ids during state check
ClosedPublic
Actions

Authored by michal on May 17 2023, 5:10 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM161a1a06509f: [web] Convert ids during state check

Summary

Because the ids will be different on the client and on the server we need to convert them during state sync. We convert them before hashing on the client side

Depends on D7851

Test Plan

Enable id conversion and load a fresh (migration are not yet implemented) web app. Log invalidKeys in processClientResponses in session-utils.js.

without the state check conversion there are invalid keys displayed
with the state check conversion there are no errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.May 17 2023, 5:10 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 17 2023, 5:10 AM

Harbormaster completed remote builds in B19445: Diff 26606.May 17 2023, 5:27 AM

michal requested review of this revision.May 17 2023, 5:27 AM

tomek accepted this revision.May 19 2023, 1:16 AM

tomek added inline comments.

lib/selectors/socket-selectors.js
108–127 ↗	(On Diff #26606)	It is a good first step but that has to become a lot more complicated before we start supporting multiple keyservers. In multi-keyserver world, each e.g. thread info might come from a different keyserver, which means that 1. converting it should use different id prefix 2. state check should happen against a different keyserver. Solving this issue now will increase the scope significantly, but at least we should create a task for it. CC @ashoat

This revision is now accepted and ready to land.May 19 2023, 1:16 AM

michal added inline comments.May 19 2023, 3:41 AM

lib/selectors/socket-selectors.js
108–127 ↗	(On Diff #26606)	ENG-3915. I feel like this is more part of the "multi-keyserver support for clients" and less part of the "new id schema".