Page MenuHomePhabricator
Differential D7865

[web] Add `subtitle` to `Modal`
ClosedPublic
Actions

Authored by atul on May 18 2023, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 10:55 AM
Unknown Object (File)
Mon, Nov 4, 1:44 PM
Unknown Object (File)
Mon, Nov 4, 1:44 PM
Unknown Object (File)
Mon, Nov 4, 1:44 PM
Unknown Object (File)
Mon, Nov 4, 1:43 PM
Unknown Object (File)
Tue, Oct 15, 2:59 AM
Unknown Object (File)
Tue, Oct 15, 2:59 AM
Unknown Object (File)
Tue, Oct 15, 2:59 AM
View All 100 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM6e3c0494a13d: [web] Add `subtitle` to `Modal`
Summary

As part of the CommunityCreation flow on web, we need to add a subtitle to the CommunityCreationMembersModal (introduced next diff) that says "You may also add members later."

This diff just sets things up for that diff by adding subtitle to Modal component.

Test Plan

Modals look as expected w/ subtitle:

d3df8d.png (1×1 px, 132 KB)

Modals look as expected w/o subtitle:

029a9f.png (1×1 px, 149 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7865 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 18 2023, 11:33 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 18 2023, 11:33 AM
atul published this revision for review.May 18 2023, 11:34 AM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B19492: Diff 26657.May 18 2023, 11:52 AM
ashoat accepted this revision.May 18 2023, 1:11 PM
This revision is now accepted and ready to land.May 18 2023, 1:11 PM
atul updated this revision to Diff 26677.May 19 2023, 9:49 AM

rebase and land

This revision was landed with ongoing or failed builds.May 19 2023, 9:50 AM
Closed by commit rCOMM6e3c0494a13d: [web] Add `subtitle` to `Modal` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6e3c0494a13d: [web] Add `subtitle` to `Modal`.
Harbormaster completed remote builds in B19512: Diff 26677.May 19 2023, 10:06 AM

Revision Contents
Changeset List

PathSize
web/
modals/
14 lines
19 lines

Diff 26677

View Options

web/modals/modal.css

Loading...
View Options

web/modals/modal.react.js

Loading...