Page MenuHomePhabricator

[native] Introduce `communityCreationButton` to `CommunityDrawerContent`
ClosedPublic

Authored by atul on May 22 2023, 11:21 AM.
Tags
None
Referenced Files
F1436525: D7924.diff
Thu, Mar 28, 12:54 PM
Unknown Object (File)
Mon, Mar 4, 12:38 AM
Unknown Object (File)
Feb 22 2024, 12:21 AM
Unknown Object (File)
Feb 22 2024, 12:17 AM
Unknown Object (File)
Feb 22 2024, 12:16 AM
Unknown Object (File)
Feb 21 2024, 10:41 PM
Unknown Object (File)
Feb 21 2024, 10:38 PM
Unknown Object (File)
Feb 21 2024, 11:35 AM
Subscribers

Details

Summary

Add community creation button to community selection drawer.

Just layout/styling for now, functionality will be added in subsequent diff.

Test Plan

Looks as expected (dark mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.55.png (2×1 px, 269 KB)

Looks as expected (light mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.45.png (2×1 px, 262 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.May 22 2023, 11:22 AM
atul edited the test plan for this revision. (Show Details)

Make sure Flow etc pass before landing please

native/navigation/community-drawer-content.react.js
120

Can we copy modalSeparator into panelSeparator to avoid mixing families of colors?

This revision is now accepted and ready to land.May 22 2023, 11:26 AM
native/navigation/community-drawer-content.react.js
120

Ah yeah good point, will update

modalSeparator -> panelSeparator

This revision was landed with ongoing or failed builds.May 22 2023, 12:02 PM
This revision was automatically updated to reflect the committed changes.