Page MenuHomePhabricator
Differential D7924

[native] Introduce `communityCreationButton` to `CommunityDrawerContent`
ClosedPublic
Actions

Authored by atul on May 22 2023, 11:21 AM.
Tags
None
Referenced Files
F5305535: D7924.id26812.diff
Tue, Apr 8, 4:59 AM
F5303915: D7924.id26811.diff
Tue, Apr 8, 4:17 AM
F5300058: D7924.id26809.diff
Tue, Apr 8, 2:13 AM
F5299675: D7924.id.diff
Tue, Apr 8, 1:26 AM
F5299070: D7924.id26810.diff
Tue, Apr 8, 12:24 AM
Unknown Object (File)
Mon, Apr 7, 3:40 AM
Unknown Object (File)
Fri, Mar 14, 7:39 PM
Unknown Object (File)
Wed, Mar 12, 10:21 PM
View All Files
Subscribers
• ted
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`
Summary

Add community creation button to community selection drawer.

Just layout/styling for now, functionality will be added in subsequent diff.

Test Plan

Looks as expected (dark mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.55.png (2×1 px, 269 KB)

Looks as expected (light mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.45.png (2×1 px, 262 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 22 2023, 11:21 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 22 2023, 11:21 AM
atul published this revision for review.May 22 2023, 11:22 AM
atul edited the test plan for this revision. (Show Details)
ashoat accepted this revision.May 22 2023, 11:26 AM

Make sure Flow etc pass before landing please

native/navigation/community-drawer-content.react.js
120 ↗(On Diff #26809)

Can we copy modalSeparator into panelSeparator to avoid mixing families of colors?

This revision is now accepted and ready to land.May 22 2023, 11:26 AM
atul added inline comments.May 22 2023, 11:36 AM
native/navigation/community-drawer-content.react.js
120 ↗(On Diff #26809)

Ah yeah good point, will update

atul updated this revision to Diff 26810.May 22 2023, 11:38 AM

modalSeparator -> panelSeparator

Herald added a subscriber: • ted. · View Herald TranscriptMay 22 2023, 11:38 AM
Harbormaster completed remote builds in B19614: Diff 26809.May 22 2023, 11:39 AM
atul updated this revision to Diff 26811.May 22 2023, 11:47 AM

rebase and land

Harbormaster completed remote builds in B19615: Diff 26810.May 22 2023, 11:55 AM
This revision was landed with ongoing or failed builds.May 22 2023, 12:02 PM
Closed by commit rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.
Harbormaster completed remote builds in B19616: Diff 26811.May 22 2023, 12:05 PM

Revision Contents
Changeset List

PathSize
native/
navigation/
48 lines
themes/
2 lines

Diff 26810

View Options

native/navigation/community-drawer-content.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

native/themes/colors.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines