Paths

Table of Contentst

[native] Add keyserver label to `CommunityConfiguration`
ClosedPublic
Actions

Authored by atul on May 23 2023, 8:19 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMaba21ee6b8e5: [native] Add keyserver label to `CommunityConfiguration`

Summary

Add keyserver label to CommunityConfiguration screen.

(For now it is hardcoded to display @ashoat)

Depends on D7950

Test Plan

Looks as expected:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-23 at 16.26.55.png (2×1 px, 86 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 23 2023, 8:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 23 2023, 8:19 PM

atul edited the summary of this revision. (Show Details)May 23 2023, 8:20 PM

atul added a parent revision: D7950: [native] Introduce `CommunityCreationNavigator`.

atul added a child revision: D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.

atul edited the test plan for this revision. (Show Details)May 23 2023, 8:27 PM

Harbormaster completed remote builds in B19702: Diff 26915.May 23 2023, 8:40 PM

atul requested review of this revision.May 23 2023, 8:40 PM

ashoat accepted this revision.May 23 2023, 9:18 PM

ashoat added inline comments.

native/community-creation/community-configuration.react.js
31 ↗	(On Diff #26915)	Why is this here instead of eg. in `unboundStyles` or something?

This revision is now accepted and ready to land.May 23 2023, 9:18 PM

atul added inline comments.May 24 2023, 2:25 PM

native/community-creation/community-configuration.react.js
31 ↗	(On Diff #26915)	No good reason not sure why I did that, will move to `unboundStyles`.

rebase

address feedback, continues to look as expected: https://blob.sh/373049.png

This revision was landed with ongoing or failed builds.May 24 2023, 3:48 PM

Closed by commit rCOMMaba21ee6b8e5: [native] Add keyserver label to `CommunityConfiguration`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaba21ee6b8e5: [native] Add keyserver label to `CommunityConfiguration`.

Harbormaster completed remote builds in B19733: Diff 26990.May 24 2023, 4:01 PM

Harbormaster completed remote builds in B19734: Diff 26991.May 24 2023, 4:06 PM

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

53 lines

Diff 26992

View Options

native/community-creation/community-configuration.react.js

[native] Add keyserver label to `CommunityConfiguration`ClosedPublicActions