Page MenuHomePhabricator
Differential D7953

[native] Add `communityNameNotice` to `CommunityConfiguration`
ClosedPublic
Actions

Authored by atul on May 23 2023, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 8:27 AM
Unknown Object (File)
Fri, Nov 29, 4:16 PM
Unknown Object (File)
Sun, Nov 17, 7:30 PM
Unknown Object (File)
Thu, Nov 7, 10:57 AM
Unknown Object (File)
Thu, Nov 7, 10:57 AM
Unknown Object (File)
Tue, Nov 5, 10:07 PM
Unknown Object (File)
Tue, Nov 5, 9:06 AM
Unknown Object (File)
Tue, Nov 5, 9:06 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM05ec431a4b17: [native] Add `communityNameNotice` to `CommunityConfiguration`
Summary

Add communityNameNotice below community name TextInput to match designs.

Depends on D7952

Test Plan

Looks as expected:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-23 at 16.21.05.png (2×1 px, 107 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 23 2023, 1:20 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 23 2023, 1:20 PM
atul edited the summary of this revision. (Show Details)May 23 2023, 1:21 PM
atul added a parent revision: D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B19704: Diff 26917.May 23 2023, 1:41 PM
atul requested review of this revision.May 23 2023, 1:41 PM
ashoat accepted this revision.May 23 2023, 2:26 PM
This revision is now accepted and ready to land.May 23 2023, 2:26 PM
atul updated this revision to Diff 26994.May 24 2023, 8:53 AM

rebase

Harbormaster completed remote builds in B19736: Diff 26994.May 24 2023, 9:13 AM
atul updated this revision to Diff 27002.May 24 2023, 9:39 AM

rebase and land

Harbormaster completed remote builds in B19743: Diff 27002.May 24 2023, 9:58 AM
Closed by commit rCOMM05ec431a4b17: [native] Add `communityNameNotice` to `CommunityConfiguration` (authored by atul). · Explain WhyMay 24 2023, 10:11 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM05ec431a4b17: [native] Add `communityNameNotice` to `CommunityConfiguration`.

Revision Contents
Changeset List

PathSize
native/
community-creation/
15 lines

Diff 27009

View Options

native/community-creation/community-configuration.react.js

Loading...