[web] Avoid global styles in accept-invite-modal.css
ClosedPublic
Actions

Authored by ashoat on May 26 2023, 7:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 7, 1:17 AM

	Unknown Object (File)
	Sat, Apr 5, 1:14 PM

	Unknown Object (File)
	Sat, Apr 5, 10:20 AM

	Unknown Object (File)
	Sat, Apr 5, 6:29 AM

	Unknown Object (File)
	Fri, Apr 4, 10:27 AM

	Unknown Object (File)
	Mar 1 2025, 10:59 PM

	Unknown Object (File)
	Mar 1 2025, 10:59 PM

	Unknown Object (File)
	Mar 1 2025, 10:57 PM

View All Files

Subscribers

None

Details

Reviewers

atul
inka
tomek
ginsu

Commits

rCOMMd2962e1bb5fd: [web] Avoid global styles in accept-invite-modal.css

Summary

This solves ENG-3945, a push-blocking issue on master.

For more context on the issue, see this Linear comment.

Test Plan

Confirm that the issue is resolved in the following places:

Chat header
Add app modal (press "+" button)
User settings page
Members modal

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 26 2023, 7:14 AM

ashoat published this revision for review.May 26 2023, 7:15 AM

atul accepted this revision.May 26 2023, 7:19 AM

This revision is now accepted and ready to land.May 26 2023, 7:19 AM

Harbormaster completed remote builds in B19792: Diff 27088.May 26 2023, 7:34 AM

Closed by commit rCOMMd2962e1bb5fd: [web] Avoid global styles in accept-invite-modal.css (authored by ashoat). · Explain WhyMay 26 2023, 7:40 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd2962e1bb5fd: [web] Avoid global styles in accept-invite-modal.css.

Revision Contents
Changeset List

Path

Size

web/

invite-links/

accept-invite-modal.css

4 lines

Diff 27089

View Options

web/invite-links/accept-invite-modal.css

[web] Avoid global styles in accept-invite-modal.cssClosedPublicActions