Page MenuHomePhabricator

[native] Delay PasswordSelection autoFocus on Android

Authored by ashoat on Fri, May 26, 7:57 AM.



While playing around with 1Password on Android, I noticed that the autofill prompt didn't appear when we autoFocused the password TextInput in PasswordSelection. However, it would appear if the user subsequently pressed / selected the TextInput manually.

Test Plan

I tested release builds with various delays for the focus on two phones: my Pixel 6a, and the older Pixel 3 in the office. 250ms consistently worked for both, while 100ms did not.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

ashoat added inline comments.
82 ↗(On Diff #27092)

It's okay to call this hook conditionally because the condition (whether the device is an Android device) is guaranteed to never change

atul added inline comments.
82 ↗(On Diff #27092)

Would it make sense to add a comment here (exact text as annotation) to make it clear to future readers?

(They could probably find the diff via git blame regardless, but wouldn't hurt?)

This revision is now accepted and ready to land.Fri, May 26, 10:36 AM
This revision was landed with ongoing or failed builds.Fri, May 26, 10:59 AM
This revision was automatically updated to reflect the committed changes.