[native] Delay PasswordSelection autoFocus on Android
ClosedPublic
Actions

Authored by ashoat on May 26 2023, 7:57 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMMa43b0f2ea47b: [native] Delay PasswordSelection autoFocus on Android

Summary

While playing around with 1Password on Android, I noticed that the autofill prompt didn't appear when we autoFocused the password TextInput in PasswordSelection. However, it would appear if the user subsequently pressed / selected the TextInput manually.

Test Plan

I tested release builds with various delays for the focus on two phones: my Pixel 6a, and the older Pixel 3 in the office. 250ms consistently worked for both, while 100ms did not.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 26 2023, 7:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 26 2023, 7:57 AM

ashoat edited the test plan for this revision. (Show Details)May 26 2023, 7:57 AM

ashoat added inline comments.

native/account/registration/password-selection.react.js
82 ↗	(On Diff #27092)	It's okay to call this hook conditionally because the condition (whether the device is an Android device) is guaranteed to never change

ashoat added a child revision: D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.May 26 2023, 8:01 AM

Harbormaster completed remote builds in B19795: Diff 27092.May 26 2023, 8:14 AM

ashoat requested review of this revision.May 26 2023, 8:14 AM

atul accepted this revision.May 26 2023, 10:36 AM

atul added inline comments.

native/account/registration/password-selection.react.js
82 ↗	(On Diff #27092)	Would it make sense to add a comment here (exact text as annotation) to make it clear to future readers? (They could probably find the diff via git blame regardless, but wouldn't hurt?)