[web] Separate out redux-persist logic from web/root.js
ClosedPublic
Actions

Authored by ashoat on Jun 1 2023, 1:51 PM.

Tags

None

Referenced Files

	F1701737: D8063.diff
	Sat, May 4, 5:32 PM

	F1698312: D8063.diff
	Sat, May 4, 12:49 AM

	Unknown Object (File)
	Thu, Apr 18, 3:36 AM

	Unknown Object (File)
	Thu, Apr 18, 3:36 AM

	Unknown Object (File)
	Thu, Apr 18, 3:36 AM

	Unknown Object (File)
	Thu, Apr 18, 3:34 AM

	Unknown Object (File)
	Feb 27 2024, 2:48 AM

	Unknown Object (File)
	Feb 23 2024, 8:30 PM

View All 20 Files

Subscribers

tomek

Details

Reviewers

kamil
michal

Commits

rCOMMad982f2b375e: [web] Separate out redux-persist logic from web/root.js

Summary

I think it's "noisy" to have this in the application entry point file.

Test Plan

Flow, run the web app and make sure it works still

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/webredux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 1 2023, 1:51 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 1:51 PM

ashoat added a child revision: D8064: [web] Include stateVersion in web PlatformDetails.Jun 1 2023, 1:53 PM

Harbormaster completed remote builds in B19968: Diff 27376.Jun 1 2023, 2:09 PM

ashoat requested review of this revision.Jun 1 2023, 2:09 PM

kamil accepted this revision.Jun 2 2023, 12:28 AM

This revision is now accepted and ready to land.Jun 2 2023, 12:28 AM

Closed by commit rCOMMad982f2b375e: [web] Separate out redux-persist logic from web/root.js (authored by ashoat). · Explain WhyJun 2 2023, 7:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMad982f2b375e: [web] Separate out redux-persist logic from web/root.js.

Revision Contents
Changeset List

Path

Size

web/

redux/

persist.js

79 lines

root.js

73 lines

Diff 27376

View Options

web/redux/persist.js