Page MenuHomePhabricator

Export CommConstants HostObject to JavaScript
ClosedPublic

Authored by marcin on Jun 2 2023, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:58 PM
Unknown Object (File)
Sun, Apr 14, 1:54 PM
Unknown Object (File)
Mar 4 2024, 11:27 PM
Subscribers

Details

Summary

This differential exports CommValidationModule to JavaScript.

Test Plan

I decided to call commConstants.NATIVE_MESSAGE_SPECS in sqlite-data-handler.js for testing purposes. So the test plan is:

  1. Build the app
  2. Apply this diff: https://gist.github.com/marcinwasowicz/da35ee527660a6a020daf88ddae61d24
  3. Open the app. Ensure the warning message like this is visible:
Object {
  "message": "C++ MessageSpec implementation missing for message types: ADD_MEMBERS, REMOVE_MEMBERS, LEAVE_THREAD, JOIN_THREAD, TOGGLE_PIN",
}

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin retitled this revision from Export CommValidationModule to JsvaScript to Export CommValidationModule to JavaScript.Jun 2 2023, 3:10 AM
marcin edited the test plan for this revision. (Show Details)
marcin requested review of this revision.Jun 2 2023, 3:23 AM

Replace TurboModule with HostObject

REmove runtime erroneously added to CommConstants constructor on native.

This revision is now accepted and ready to land.Jun 6 2023, 2:38 AM
marcin retitled this revision from Export CommValidationModule to JavaScript to Export CommConstants HostObject to JavaScript.Jun 6 2023, 2:39 AM
marcin edited the test plan for this revision. (Show Details)