Page MenuHomePhabricator
Differential D8088

[native] Move some types from avatar-selection.react.js to registration-types.js
ClosedPublic
Actions

Authored by ashoat on Jun 4 2023, 10:06 AM.
Tags
None
Referenced Files
F3352443: D8088.diff
Sat, Nov 23, 5:57 AM
Unknown Object (File)
Wed, Nov 6, 3:45 PM
Unknown Object (File)
Tue, Nov 5, 10:08 PM
Unknown Object (File)
Tue, Nov 5, 10:08 PM
Unknown Object (File)
Tue, Nov 5, 9:10 AM
Unknown Object (File)
Mon, Nov 4, 10:50 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM1e9601c6fc0b: [native] Move some types from avatar-selection.react.js to registration-types.js
Summary

Going to use these types in a new place, so figured it would be better to export them from the shared types file

Depends on D8087

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jun 4 2023, 10:06 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 4 2023, 10:06 AM
ashoat mentioned this in D8089: [native] Rename accountSelections to accountSelection.Jun 4 2023, 10:07 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 4 2023, 10:16 AM
Harbormaster failed remote builds in B20009: Diff 27426!
ashoat added a child revision: D8089: [native] Rename accountSelections to accountSelection.Jun 4 2023, 2:41 PM
ashoat updated this revision to Diff 27429.Jun 4 2023, 2:41 PM

Rebase

Harbormaster completed remote builds in B20012: Diff 27429.Jun 4 2023, 3:01 PM
ashoat requested review of this revision.Jun 4 2023, 3:01 PM
atul accepted this revision.Jun 5 2023, 7:36 AM
This revision is now accepted and ready to land.Jun 5 2023, 7:36 AM
Closed by commit rCOMM1e9601c6fc0b: [native] Move some types from avatar-selection.react.js to registration-types.js (authored by ashoat). · Explain WhyJun 6 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.
ashoat mentioned this in rCOMMfb4cfe1c45fb: [native] Rename accountSelections to accountSelection.
ashoat added a commit: rCOMM1e9601c6fc0b: [native] Move some types from avatar-selection.react.js to registration-types.js.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
39 lines
35 lines

Diff 27426

View Options

native/account/registration/avatar-selection.react.js

Loading...
View Options

native/account/registration/registration-types.js

Loading...