Page MenuHomePhabricator
Differential D8116

[web-db] change Error type to string
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 9:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 5:29 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:12 AM
Unknown Object (File)
Sun, Mar 2, 1:01 PM
Unknown Object (File)
Fri, Feb 28, 12:42 AM
Unknown Object (File)
Thu, Feb 27, 3:33 AM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMMab9fe33b4536: [web-db] change Error type to string
Summary

Because of the Safari problems with structured clone algorithm we can not send objects with methods between threads.
Error objects has some methods inside core definition.

That was causing DataCloneError: The object could not be cloned..

Test Plan

Check is error are properly handled.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
database/
utils/
4 lines
worker/
4 lines
types/
2 lines

Diff 27758

View Options

web/database/utils/WorkerConnectionProxy.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

web/database/worker/db-worker.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

web/types/worker-types.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines