Page MenuHomePhabricator
Differential D8118

[web-db] add `extractable` param while creating crypto key
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 10:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 5:29 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:15 AM
Unknown Object (File)
Thu, Mar 13, 6:12 AM
Unknown Object (File)
Tue, Feb 25, 4:57 AM
Unknown Object (File)
Mon, Feb 24, 3:05 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key
Summary

On Safari we need to export the key to send this to worker in form it is transferable. (context)

Depends on D8117

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 6 2023, 10:08 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 10:08 AM
kamil added a child revision: D8119: [web-db] add methods to import/export key to `JWK` format.Jun 6 2023, 10:09 AM
Harbormaster completed remote builds in B20055: Diff 27485.Jun 6 2023, 10:25 AM
kamil published this revision for review.Jun 7 2023, 1:36 AM
kamil added inline comments.
web/database/utils/worker-crypto-utils.js
11 ↗(On Diff #27485)

this could be one argument but in this case, I want this to be more descriptive from caller's perspective

ashoat added inline comments.Jun 7 2023, 2:07 PM
web/database/utils/worker-crypto-utils.js
13 ↗(On Diff #27485)

Inputs should always be $ReadOnly

tomek accepted this revision.Jun 13 2023, 3:26 AM
This revision is now accepted and ready to land.Jun 13 2023, 3:26 AM
kamil updated this revision to Diff 27747.Jun 14 2023, 7:05 AM

make params read-only

This revision was landed with ongoing or failed builds.Jun 14 2023, 10:14 AM
Closed by commit rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
8 lines
6 lines
worker/
4 lines

Diff 27760

View Options

web/database/utils/worker-crypto-utils.js

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/database/utils/worker-crypto-utlis.test.js

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/database/worker/db-worker.js

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines