Page MenuHomePhabricator
Differential D8118

[web-db] add `extractable` param while creating crypto key
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 10:08 AM.
Tags
None
Referenced Files
F3673145: D8118.diff
Mon, Jan 6, 5:51 AM
Unknown Object (File)
Sat, Jan 4, 5:22 PM
Unknown Object (File)
Sat, Dec 28, 8:46 PM
Unknown Object (File)
Sat, Dec 28, 8:46 PM
Unknown Object (File)
Sat, Dec 28, 8:46 PM
Unknown Object (File)
Sat, Dec 28, 8:42 PM
Unknown Object (File)
Sat, Dec 28, 8:20 PM
Unknown Object (File)
Thu, Dec 26, 3:32 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key
Summary

On Safari we need to export the key to send this to worker in form it is transferable. (context)

Depends on D8117

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 6 2023, 10:08 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 10:08 AM
kamil added a child revision: D8119: [web-db] add methods to import/export key to `JWK` format.Jun 6 2023, 10:09 AM
Harbormaster completed remote builds in B20055: Diff 27485.Jun 6 2023, 10:25 AM
kamil published this revision for review.Jun 7 2023, 1:36 AM
kamil added inline comments.
web/database/utils/worker-crypto-utils.js
11 ↗(On Diff #27485)

this could be one argument but in this case, I want this to be more descriptive from caller's perspective

ashoat added inline comments.Jun 7 2023, 2:07 PM
web/database/utils/worker-crypto-utils.js
13 ↗(On Diff #27485)

Inputs should always be $ReadOnly

tomek accepted this revision.Jun 13 2023, 3:26 AM
This revision is now accepted and ready to land.Jun 13 2023, 3:26 AM
kamil updated this revision to Diff 27747.Jun 14 2023, 7:05 AM

make params read-only

This revision was landed with ongoing or failed builds.Jun 14 2023, 10:14 AM
Closed by commit rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
8 lines
6 lines
worker/
4 lines

Diff 27760

View Options

web/database/utils/worker-crypto-utils.js

Loading...
View Options

web/database/utils/worker-crypto-utlis.test.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...