Paths

Table of Contentst

[web-db] add `extractable` param while creating crypto key
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 5:08 PM.

Details

Reviewers

michal
tomek

Commits

rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key

Summary

On Safari we need to export the key to send this to worker in form it is transferable. (context)

Depends on D8117

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 6 2023, 5:08 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 5:08 PM

kamil added a child revision: D8119: [web-db] add methods to import/export key to `JWK` format.Jun 6 2023, 5:09 PM

Harbormaster completed remote builds in B20055: Diff 27485.Jun 6 2023, 5:25 PM

kamil published this revision for review.Jun 7 2023, 8:36 AM

kamil added inline comments.

web/database/utils/worker-crypto-utils.js
11 ↗	(On Diff #27485)	this could be one argument but in this case, I want this to be more descriptive from caller's perspective

ashoat added inline comments.Jun 7 2023, 9:07 PM

web/database/utils/worker-crypto-utils.js
13 ↗	(On Diff #27485)	Inputs should always be `$ReadOnly`

tomek accepted this revision.Jun 13 2023, 10:26 AM

This revision is now accepted and ready to land.Jun 13 2023, 10:26 AM

make params read-only

This revision was landed with ongoing or failed builds.Jun 14 2023, 5:14 PM

Closed by commit rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key.

Revision Contents
Changeset List

Path

Size

web/

database/

utils/

worker-crypto-utils.js

8 lines

worker-crypto-utlis.test.js

6 lines

worker/

db-worker.js

4 lines

Diff 27760

View Options

web/database/utils/worker-crypto-utils.js

View Options

web/database/utils/worker-crypto-utlis.test.js

View Options

web/database/worker/db-worker.js

[web-db] add `extractable` param while creating crypto keyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27760

web/database/utils/worker-crypto-utils.js

web/database/utils/worker-crypto-utlis.test.js

web/database/worker/db-worker.js

[web-db] add `extractable` param while creating crypto key
ClosedPublic
Actions

Revision Contents
Changeset List