Page MenuHomePhabricator

[keyserver] Validate search endpoint response
ClosedPublic

Authored by inka on Jun 7 2023, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 8:11 AM
Unknown Object (File)
Sat, Mar 22, 4:19 PM
Unknown Object (File)
Tue, Mar 11, 5:34 PM
Unknown Object (File)
Tue, Mar 11, 5:31 PM
Unknown Object (File)
Tue, Mar 11, 4:02 PM
Unknown Object (File)
Tue, Mar 11, 4:02 PM
Unknown Object (File)
Tue, Mar 11, 10:40 AM
Unknown Object (File)
Thu, Mar 6, 3:03 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3939/validate-search-endpoint
Search endpoint was missing a validation on the response

Test Plan

Called the search endpoint from client, checked that no errors / warnings appear

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jun 7 2023, 6:50 AM

The output validation looks good but you also need to modify the input logic.

keyserver/src/responders/message-responders.js
496–499 ↗(On Diff #27523)
This revision is now accepted and ready to land.Jun 12 2023, 2:35 AM

(Restarted failing iOS build)