Page MenuHomePhabricator
Differential D8143

[keyserver] Validate search endpoint response
ClosedPublic
Actions

Authored by inka on Jun 7 2023, 6:33 AM.
Tags
None
Referenced Files
F6184565: D8143.id.diff
Wed, Apr 23, 10:29 AM
F6171052: D8143.id27646.diff
Wed, Apr 23, 2:10 AM
F6165330: D8143.id27651.diff
Tue, Apr 22, 10:53 PM
F6163055: D8143.id27523.diff
Tue, Apr 22, 7:54 PM
F6155907: D8143.diff
Tue, Apr 22, 4:43 PM
Unknown Object (File)
Wed, Apr 16, 5:10 PM
Unknown Object (File)
Sat, Apr 12, 6:00 PM
Unknown Object (File)
Sun, Apr 6, 11:35 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
Commits
rCOMMac297e5134ca: [keyserver] Validate search endpoint response
Summary

issue: https://linear.app/comm/issue/ENG-3939/validate-search-endpoint
Search endpoint was missing a validation on the response

Test Plan

Called the search endpoint from client, checked that no errors / warnings appear

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 7 2023, 6:33 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2023, 6:33 AM
inka added 1 blocking reviewer(s): michal.Jun 7 2023, 6:33 AM
Harbormaster completed remote builds in B20088: Diff 27523.Jun 7 2023, 6:50 AM
inka requested review of this revision.Jun 7 2023, 6:50 AM
michal accepted this revision.Jun 12 2023, 2:35 AM

The output validation looks good but you also need to modify the input logic.

keyserver/src/responders/message-responders.js
496–499 ↗(On Diff #27523)
This revision is now accepted and ready to land.Jun 12 2023, 2:35 AM
inka updated this revision to Diff 27646.Jun 12 2023, 7:16 AM

Modify input logic

Harbormaster failed remote builds in B20181: Diff 27646!Jun 12 2023, 7:18 AM
inka updated this revision to Diff 27651.Jun 12 2023, 7:29 AM

Rebase

Harbormaster failed remote builds in B20185: Diff 27651!Jun 12 2023, 7:43 AM
atul added a subscriber: atul.Jun 12 2023, 9:35 AM

(Restarted failing iOS build)

Harbormaster completed remote builds in B20185: Diff 27651.Jun 12 2023, 9:44 AM
Closed by commit rCOMMac297e5134ca: [keyserver] Validate search endpoint response (authored by • InkaSokolowska). · Explain WhyJun 12 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMac297e5134ca: [keyserver] Validate search endpoint response.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
22 lines

Diff 27651

View Options

keyserver/src/responders/message-responders.js

Loading...