Page MenuHomePhabricator

[native] Don't show loading spinner during avatar server call in registration screen
AbandonedPublic

Authored by ashoat on Jun 8 2023, 6:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 2:21 AM
Unknown Object (File)
Thu, Apr 18, 2:21 AM
Unknown Object (File)
Thu, Apr 18, 2:17 AM
Unknown Object (File)
Mar 5 2024, 11:55 PM
Unknown Object (File)
Mar 5 2024, 11:55 PM
Unknown Object (File)
Feb 23 2024, 7:39 PM
Unknown Object (File)
Feb 23 2024, 6:01 PM
Unknown Object (File)
Feb 23 2024, 4:00 PM
Subscribers

Details

Reviewers
atul
ginsu
Summary

We already have a loading spinner on the button, and it feels unexpected for the avatar spinner to randomly appear some time after the user presses the button (after the registration server call concludes and the avatar one starts).

Depends on D8150

Test Plan

The whole stack was tested as follows:

  1. Try creating an account with the default avatar
  2. Try creating an account with an emoji avatar
  3. Try creating an account with an image avatar (that needs to be uploaded)
  4. Try creating an Ethereum account with an ENS avatar

I made sure of the following:

  1. Loading spinner appeared on the button, not on the avatar, and was present throughout
  2. After the RegistrationNavigator is dismissed, the avatar that appears for the user's PRIVATE chat in the ChatThreadList is correct
  3. Subsequent delete-account-and-then-register-again worked correctly
  4. Various error cases are triggered correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage