[native] Move final registration step to RegistrationTerms
ClosedPublic
Actions

Authored by ashoat on Jun 9 2023, 12:10 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms

Summary

This diff makes it so RegistrationTerms is the last screen in the wizard, and so that pressing the "Register" button triggers registration.

Depends on D8162

Test Plan

I tried going through the wizard and confirmed it works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 9 2023, 12:10 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 9 2023, 12:10 PM

ashoat added a child revision: D8164: [native] Style RegistrationTerms.Jun 9 2023, 12:10 PM

ashoat mentioned this in D8151: [native] Don't show loading spinner during avatar server call in registration screen.Jun 9 2023, 12:19 PM

Rebase

ashoat added inline comments.Jun 9 2023, 12:23 PM

native/account/registration/avatar-selection.react.js
113 ↗	(On Diff #27595)	Instead of disabling `registrationMode` while `registrationInProgress` is true, now that registration happens on another screen we can just disable it when this screen is unfocused

Harbormaster completed remote builds in B20143: Diff 27593.Jun 9 2023, 12:26 PM

ashoat published this revision for review.Jun 9 2023, 12:29 PM

atul accepted this revision.Jun 9 2023, 12:31 PM

This revision is now accepted and ready to land.Jun 9 2023, 12:31 PM

Harbormaster completed remote builds in B20145: Diff 27595.Jun 9 2023, 12:35 PM

Realized useFocusEffect doesn't work because there are two other auxiliary screens we use for setting avatars. Reworked it to enable registrationMode while any of the 3 relevant screens are in focus

Harbormaster completed remote builds in B20148: Diff 27598.Jun 9 2023, 1:01 PM

Closed by commit rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms (authored by ashoat). · Explain WhyJun 9 2023, 2:24 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms.