Page MenuHomePhabricator
Differential D8163

[native] Move final registration step to RegistrationTerms
ClosedPublic
Actions

Authored by ashoat on Jun 9 2023, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 13 2025, 2:14 PM
Unknown Object (File)
Mar 13 2025, 2:14 PM
Unknown Object (File)
Mar 13 2025, 2:14 PM
Unknown Object (File)
Mar 13 2025, 2:14 PM
Unknown Object (File)
Mar 13 2025, 2:14 PM
Unknown Object (File)
Mar 13 2025, 2:10 PM
Unknown Object (File)
Mar 9 2025, 7:57 PM
Unknown Object (File)
Mar 9 2025, 7:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms
Summary

This diff makes it so RegistrationTerms is the last screen in the wizard, and so that pressing the "Register" button triggers registration.

Depends on D8162

Test Plan

I tried going through the wizard and confirmed it works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 9 2023, 12:10 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 9 2023, 12:10 PM
ashoat added a child revision: D8164: [native] Style RegistrationTerms.Jun 9 2023, 12:10 PM
ashoat mentioned this in D8151: [native] Don't show loading spinner during avatar server call in registration screen.Jun 9 2023, 12:19 PM
ashoat updated this revision to Diff 27595.Jun 9 2023, 12:20 PM

Rebase

ashoat added inline comments.Jun 9 2023, 12:23 PM
native/account/registration/avatar-selection.react.js
113 ↗(On Diff #27595)

Instead of disabling registrationMode while registrationInProgress is true, now that registration happens on another screen we can just disable it when this screen is unfocused

Harbormaster completed remote builds in B20143: Diff 27593.Jun 9 2023, 12:26 PM
ashoat published this revision for review.Jun 9 2023, 12:29 PM
atul accepted this revision.Jun 9 2023, 12:31 PM
This revision is now accepted and ready to land.Jun 9 2023, 12:31 PM
Harbormaster completed remote builds in B20145: Diff 27595.Jun 9 2023, 12:35 PM
ashoat updated this revision to Diff 27598.Jun 9 2023, 12:44 PM

Realized useFocusEffect doesn't work because there are two other auxiliary screens we use for setting avatars. Reworked it to enable registrationMode while any of the 3 relevant screens are in focus

Harbormaster completed remote builds in B20148: Diff 27598.Jun 9 2023, 1:01 PM
Closed by commit rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms (authored by ashoat). · Explain WhyJun 9 2023, 2:24 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM61730cb3c25b: [native] Move final registration step to RegistrationTerms.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
51 lines
22 lines
navigation/
12 lines

Diff 27621

View Options

native/account/registration/avatar-selection.react.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

native/account/registration/registration-terms.react.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

native/navigation/nav-selectors.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };