[native] Make callback param optional in useUploadSelectedMedia avatar hook
ClosedPublic
Actions

Authored by ashoat on Jun 8 2023, 6:55 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMMdc61e79388dd: [native] Make callback param optional in useUploadSelectedMedia avatar hook

Summary

We don't need this callback param in the registration flow, since we're already wrapping the call to useRegistrationServerCall with some loading state.

Depends on D8149

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 8 2023, 6:55 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 8 2023, 6:55 AM

ashoat added a child revision: D8151: [native] Don't show loading spinner during avatar server call in registration screen.Jun 8 2023, 6:56 AM

Harbormaster completed remote builds in B20110: Diff 27554.Jun 8 2023, 7:12 AM

ashoat requested review of this revision.Jun 8 2023, 7:12 AM

ashoat removed a child revision: D8151: [native] Don't show loading spinner during avatar server call in registration screen.Jun 9 2023, 12:20 PM

ashoat added a child revision: D8152: [native] Set user avatar after registering in registration flow.

atul accepted this revision.Jun 9 2023, 12:23 PM

This revision is now accepted and ready to land.Jun 9 2023, 12:23 PM

Closed by commit rCOMMdc61e79388dd: [native] Make callback param optional in useUploadSelectedMedia avatar hook (authored by ashoat). · Explain WhyJun 9 2023, 2:24 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdc61e79388dd: [native] Make callback param optional in useUploadSelectedMedia avatar hook.

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

10 lines

Diff 27616

View Options

native/avatars/avatar-hooks.js

This file was moved to services/lib/src/DatabaseEntitiesTools.h.

[native] Make callback param optional in useUploadSelectedMedia avatar hookClosedPublicActions