[shellcheck] Disable SC2317 in comm-dev.sh
ClosedPublic
Actions

Authored by bartek on Jun 12 2023, 3:15 AM.

Details

Reviewers

• jon
atul

Commits

rCOMMecb60d9c44f5: [shellcheck] Disable SC2317 in comm-dev.sh

Summary

Fixes CI shellcheck failure.
Shellcheck 0.9.0 has been released and it has a new check SC2317 enabled by default
which caused CI to fail. This check is not available in 0.8.0 which is the version
we use locally.

Test Plan

Ensured both shellcheck 0.8.0 and 0.9.0 pass locally. Ran CI.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 12 2023, 3:15 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2023, 3:15 AM

Harbormaster completed remote builds in B20175: Diff 27640.Jun 12 2023, 3:33 AM

bartek requested review of this revision.Jun 12 2023, 3:33 AM

• jon accepted this revision.Jun 12 2023, 7:15 AM

This revision is now accepted and ready to land.Jun 12 2023, 7:15 AM

• jon requested changes to this revision.Jun 12 2023, 7:17 AM

• jon added inline comments.

scripts/comm-dev.sh
56 ↗	(On Diff #27640)	actually, i think we should just remove these `exit 1`'s.
81 ↗	(On Diff #27640)	actually, i think we should just remove these `exit 1`'s.