Page MenuHomePhabricator
Differential D8181

[shellcheck] Disable SC2317 in comm-dev.sh
ClosedPublic
Actions

Authored by bartek on Jun 12 2023, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 4:50 PM
Unknown Object (File)
Sun, Nov 10, 9:00 PM
Unknown Object (File)
Sun, Nov 10, 9:00 PM
Unknown Object (File)
Sun, Nov 10, 8:59 PM
Unknown Object (File)
Mon, Nov 4, 10:56 AM
Unknown Object (File)
Mon, Nov 4, 1:40 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
atul
Commits
rCOMMecb60d9c44f5: [shellcheck] Disable SC2317 in comm-dev.sh
Summary

Fixes CI shellcheck failure.
Shellcheck 0.9.0 has been released and it has a new check SC2317 enabled by default
which caused CI to fail. This check is not available in 0.8.0 which is the version
we use locally.

Test Plan

Ensured both shellcheck 0.8.0 and 0.9.0 pass locally. Ran CI.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jun 12 2023, 3:15 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2023, 3:15 AM
Harbormaster completed remote builds in B20175: Diff 27640.Jun 12 2023, 3:33 AM
bartek requested review of this revision.Jun 12 2023, 3:33 AM
• jon accepted this revision.Jun 12 2023, 7:15 AM
This revision is now accepted and ready to land.Jun 12 2023, 7:15 AM
• jon requested changes to this revision.Jun 12 2023, 7:17 AM
• jon added inline comments.
scripts/comm-dev.sh
56 ↗(On Diff #27640)

actually, i think we should just remove these exit 1's.

81 ↗(On Diff #27640)

actually, i think we should just remove these exit 1's.

This revision now requires changes to proceed.Jun 12 2023, 7:17 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Jun 12 2023, 7:18 AM
Closed by commit rCOMMecb60d9c44f5: [shellcheck] Disable SC2317 in comm-dev.sh (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMecb60d9c44f5: [shellcheck] Disable SC2317 in comm-dev.sh.
bartek added a comment.EditedJun 12 2023, 7:19 AM

Ouch, sorry, landed this ASAP to unblock CI. Will apply your suggestion in another diff

Edit: D8184

bartek mentioned this in D8184: comm-dev.sh - remove unnecessary 'exit 1's.Jun 12 2023, 7:28 AM
bartek mentioned this in rCOMMd978cf9b6c46: comm-dev.sh - remove unnecessary 'exit 1's.Jun 12 2023, 11:18 PM

Revision Contents
Changeset List

PathSize
scripts/
2 lines

Diff 27647

View Options

scripts/comm-dev.sh

Loading...