Page MenuHomePhabricator
Differential D8183

[web] remove avatar feature flag logic
ClosedPublic
Actions

Authored by ginsu on Jun 12 2023, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 1, 12:54 PM
Unknown Object (File)
Mon, Sep 30, 3:49 AM
Unknown Object (File)
Sun, Sep 29, 8:40 AM
Unknown Object (File)
Sun, Sep 29, 8:09 AM
Unknown Object (File)
Sat, Sep 21, 7:39 AM
Unknown Object (File)
Sun, Sep 15, 1:36 AM
Unknown Object (File)
Fri, Sep 13, 11:34 PM
Unknown Object (File)
Wed, Sep 11, 9:56 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
Commits
rCOMM5cf694e34a65: [web] remove avatar feature flag logic
Summary

Now that avatars is in a stable spot, we can remove the return true feature flag function and the related logic to conditonally render avatars based on it

Test Plan

Made sure that as I was removing the feature flag code, the avatar rendering looked the same

Diff Detail

Repository
rCOMM Comm
Branch
eng-3413
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 12 2023, 7:05 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2023, 7:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2023, 7:06 AM
Harbormaster failed remote builds in B20180: Diff 27645!
ginsu requested review of this revision.Jun 12 2023, 7:07 AM
ginsu added reviewers: atul, rohan.
ginsu updated this revision to Diff 27649.Jun 12 2023, 7:23 AM

forgot to remove unused class

Harbormaster failed remote builds in B20183: Diff 27649!Jun 12 2023, 7:24 AM
atul accepted this revision.Jun 12 2023, 7:39 AM

Can you pull in latest changes before landing and ensure CI checks pass

This revision is now accepted and ready to land.Jun 12 2023, 7:39 AM
ginsu updated this revision to Diff 27664.Jun 12 2023, 1:20 PM

rebase before landing

Harbormaster failed remote builds in B20194: Diff 27664!Jun 12 2023, 1:30 PM
Harbormaster completed remote builds in B20194: Diff 27664.Jun 12 2023, 1:51 PM
Closed by commit rCOMM5cf694e34a65: [web] remove avatar feature flag logic (authored by ginsu). · Explain WhyJun 12 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5cf694e34a65: [web] remove avatar feature flag logic.

Revision Contents
Changeset List

Diff 27645

View Options

web/chat/chat-message-list.css

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/chat/chat-thread-list-item.react.js

Loading...
View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/inline-engagement.css

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/thread-top-bar.css

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/chat/typeahead-tooltip.css

Loading...
View Options

web/components/avatar.react.js

Loading...
View Options

web/modals/chat/message-reactions-modal.react.js

Loading...
View Options

web/modals/components/add-members-item.react.js

Loading...
View Options

web/modals/threads/sidebars/sidebar.react.js

Loading...
View Options

web/modals/threads/subchannels/subchannel.react.js

Loading...
View Options

web/modals/threads/thread-picker-modal.react.js

Loading...
View Options

web/navigation-panels/nav-state-info-bar.css

Loading...
View Options

web/navigation-panels/nav-state-info-bar.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...
View Options

web/settings/relationship/block-list-row.react.js

Loading...
View Options

web/settings/relationship/friend-list-row.react.js

Loading...
View Options

web/sidebar/community-drawer-item.react.js

Loading...
View Options

web/utils/avatar-utils.js

Loading...
View Options

web/utils/typeahead-utils.js

Loading...