When landing page is configured with / base path, it receives all the requests before /invite/:secret can be handled - this route should be declared before any other router.
Details
Details
Configure landing page so that it is server on /. Open /invite/abc route and check if a user is redirected to {commBasePath}/handle/invite/abc. This testing procedure still is far from our prod setup, but should be enough to check if the solution is correct.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Tests pass on CI but aren't reported to Phabricator due to https://linear.app/comm/issue/ENG-4095/ci-freeze-on-build-status
| keyserver/src/keyserver.js | ||
|---|---|---|
| 130–134 ↗ | (On Diff #27746) | Maybe add a comment that this line must be above other routers to avoid being caught by their wildcard route. |