Page MenuHomePhabricator

[keyserver] Allow routing to invite endpoint
ClosedPublic

Authored by tomek on Jun 14 2023, 7:03 AM.
Tags
None
Referenced Files
F3639963: D8209.diff
Sat, Jan 4, 9:28 AM
Unknown Object (File)
Wed, Dec 18, 5:01 AM
Unknown Object (File)
Wed, Dec 18, 5:01 AM
Unknown Object (File)
Wed, Dec 18, 5:01 AM
Unknown Object (File)
Wed, Dec 18, 5:01 AM
Unknown Object (File)
Wed, Dec 18, 4:54 AM
Unknown Object (File)
Dec 2 2024, 2:48 PM
Unknown Object (File)
Nov 23 2024, 1:03 PM
Subscribers

Details

Summary

When landing page is configured with / base path, it receives all the requests before /invite/:secret can be handled - this route should be declared before any other router.

Test Plan

Configure landing page so that it is server on /. Open /invite/abc route and check if a user is redirected to {commBasePath}/handle/invite/abc. This testing procedure still is far from our prod setup, but should be enough to check if the solution is correct.

Diff Detail

Repository
rCOMM Comm
Branch
invite-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek published this revision for review.Jun 15 2023, 3:22 AM

Tests pass on CI but aren't reported to Phabricator due to https://linear.app/comm/issue/ENG-4095/ci-freeze-on-build-status

This revision is now accepted and ready to land.Jun 15 2023, 3:34 AM
bartek added inline comments.
keyserver/src/keyserver.js
130–134

Maybe add a comment that this line must be above other routers to avoid being caught by their wildcard route.