[native] introduce EmojiSelection type
ClosedPublic
Actions

Authored by ginsu on Jun 15 2023, 10:18 AM.

Details

Reviewers

atul
kamil

Commits

rCOMM44968631d0b6: [native] introduce EmojiSelection type

Summary

Created a new type called EmojiSelection based on this type found in the rn-emoji-keyboard codebase. This should be an improvement to what we had before ({ emoji: string, ... })

Test Plan

Everything still works and when I log out emoji in onEmojiSelected in native/avatars/emoji-avatar-creation.react.js I now get the improved field suggestions for emoji

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 15 2023, 10:18 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 15 2023, 10:18 AM

ginsu published this revision for review.Jun 15 2023, 10:21 AM

ginsu edited the summary of this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B20286: Diff 27808.Jun 15 2023, 10:36 AM

ginsu added a child revision: D8228: [native] add recently used category to emoji picker.Jun 15 2023, 11:18 AM

atul accepted this revision.Jun 15 2023, 6:40 PM

atul added inline comments.

native/components/emoji-keyboard.react.js
6–13 ↗	(On Diff #27808)	Wonder if there's a better name for this type than `EmojiType` since `alreadySelected` seems like it's describing some aspect of the state of the emoji picker rather than the emoji being selected? Maybe `EmojiSelection`?