Page MenuHomePhabricator

[landing] Monitor WalletConnect modal height
ClosedPublic

Authored by ashoat on Jun 19 2023, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 6:35 PM
Unknown Object (File)
Tue, Nov 26, 4:32 PM
Unknown Object (File)
Wed, Nov 13, 4:57 PM
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Subscribers

Details

Summary

See parent diff:

As part of the WalletConnect 2 update, RainbowKit is now using WalletConnect's Web3Modal.

This modal changes sizes more frequently, and as a result later diffs will complicate the code for monitoring the WalletConnect modal.

This diff implements the aforementioned "complicated" logic for monitoring the height of the WalletConnect modal.

Depends on D8251

Test Plan

Tested with the rest of the stack. I tested all three SIWE endpoints:

  1. Web
  2. Native (old flow)
  3. Native (new flow)

For each, I tested both Rainbow and WalletConnect (both of which need WalletConnect), and navigated around the WalletConnect modal to various places.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage