[native] Update native to match new landing SIWE behavior
ClosedPublic
Actions

Authored by ashoat on Jun 19 2023, 4:57 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM5d2c35d3748f: [native] Update native to match new landing SIWE behavior

Summary

I separated this out into its own commit to make it easier to test the old native with the new landing. I wanted to make sure we didn't break old clients.

Resize BottomSheet to specific values when the WalletConnect modal is open.
Style the handle to match the WebView when the WalletConnect modal is open.

Depends on D8253

Test Plan

Tested with the rest of the stack. I tested all three SIWE endpoints:

Web
Native (old flow)
Native (new flow)

For each, I tested both Rainbow and WalletConnect (both of which need WalletConnect), and navigated around the WalletConnect modal to various places.

I also tested both the new native client (as of this diff) as well as the old one (as of the previous diff). The new client resizes better, but the old client is still usable.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 19 2023, 4:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2023, 4:58 PM

ashoat added inline comments.Jun 19 2023, 5:02 PM

native/account/siwe-panel.react.js
100–104 ↗	(On Diff #27872)	I figured this out empirically. The WalletConnect had three different sizes from what I could tell, and these conditions work well for all three. For whatever reason, the smallest size is different than the other two sizes. Without this conditional, the `backgroundStyle` below doesn't "blend into" the background color of the `WebView`. If the value is too low, the rounded corners from the `WebView` are visible. If the value is too high, then part of the `WebView` is cut off.
165 ↗	(On Diff #27872)	This is the color of the top of the WalletConnect modal and it makes things blend together nicely