[native] Update native to match new landing SIWE behavior
ClosedPublic
Actions

Authored by ashoat on Jun 19 2023, 4:57 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM5d2c35d3748f: [native] Update native to match new landing SIWE behavior

Summary

I separated this out into its own commit to make it easier to test the old native with the new landing. I wanted to make sure we didn't break old clients.

Resize BottomSheet to specific values when the WalletConnect modal is open.
Style the handle to match the WebView when the WalletConnect modal is open.

Depends on D8253

Test Plan

Tested with the rest of the stack. I tested all three SIWE endpoints:

Web
Native (old flow)
Native (new flow)

For each, I tested both Rainbow and WalletConnect (both of which need WalletConnect), and navigated around the WalletConnect modal to various places.

I also tested both the new native client (as of this diff) as well as the old one (as of the previous diff). The new client resizes better, but the old client is still usable.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 19 2023, 4:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2023, 4:58 PM

ashoat added inline comments.Jun 19 2023, 5:02 PM

native/account/siwe-panel.react.js
100–104 ↗	(On Diff #27872)	I figured this out empirically. The WalletConnect had three different sizes from what I could tell, and these conditions work well for all three. For whatever reason, the smallest size is different than the other two sizes. Without this conditional, the `backgroundStyle` below doesn't "blend into" the background color of the `WebView`. If the value is too low, the rounded corners from the `WebView` are visible. If the value is too high, then part of the `WebView` is cut off.
165 ↗	(On Diff #27872)	This is the color of the top of the WalletConnect modal and it makes things blend together nicely

Harbormaster completed remote builds in B20334: Diff 27872.Jun 19 2023, 5:26 PM

ashoat requested review of this revision.Jun 19 2023, 5:26 PM

atul accepted this revision.Jun 21 2023, 6:50 AM

This revision is now accepted and ready to land.Jun 21 2023, 6:50 AM

Closed by commit rCOMM5d2c35d3748f: [native] Update native to match new landing SIWE behavior (authored by ashoat). · Explain WhyJun 21 2023, 7:03 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5d2c35d3748f: [native] Update native to match new landing SIWE behavior.

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

23 lines

Diff 27934

View Options

native/account/siwe-panel.react.js

// @flow		// @flow

import olm from '@commapp/olm';		import olm from '@commapp/olm';
import type {		import type {
Account as OlmAccount,		Account as OlmAccount,
Utility as OlmUtility,		Utility as OlmUtility,
		Session as OlmSession,
} from '@commapp/olm';		} from '@commapp/olm';
import uuid from 'uuid';		import uuid from 'uuid';

type PickledOlmAccount = {		type PickledOlmAccount = {
+picklingKey: string,		+picklingKey: string,
+pickledAccount: string,		+pickledAccount: string,
};		};

Show All 22 Lines	): Promise<OlmAccount> {

account.unpickle(		account.unpickle(
pickledOlmAccount.picklingKey,		pickledOlmAccount.picklingKey,
pickledOlmAccount.pickledAccount,		pickledOlmAccount.pickledAccount,
);		);
return account;		return account;
}		}

		async function createPickledOlmSession(
		account: OlmAccount,
		accountPicklingKey: string,
		initialEncryptedMessage: string,
		): Promise<string> {
		await olm.init();
		const session = new olm.Session();
		session.create_inbound(account, initialEncryptedMessage);
		account.remove_one_time_keys(session);
		session.decrypt(0, initialEncryptedMessage);
		ashoatUnsubmitted Not Done Inline Actions Let's avoid passing constants as number literals like this. Instead, please define something like eg. `threadTypes`, so that this code is more "readable" at the callsite (eg. we would see something like `olmMessageTypes.TEXT` or something) ashoat: Let's avoid passing constants as number literals like this. Instead, please define something…
		return session.pickle(accountPicklingKey);
		}

		async function unpickleOlmSession(
		pickledSession: string,
		picklingKey: string,
		): Promise<OlmSession> {
		await olm.init();
		const session = new olm.Session();
		session.unpickle(picklingKey, pickledSession);
		return session;
		}

let cachedOLMUtility: OlmUtility;		let cachedOLMUtility: OlmUtility;
function getOlmUtility(): OlmUtility {		function getOlmUtility(): OlmUtility {
if (cachedOLMUtility) {		if (cachedOLMUtility) {
return cachedOLMUtility;		return cachedOLMUtility;
}		}
cachedOLMUtility = new olm.Utility();		cachedOLMUtility = new olm.Utility();
return cachedOLMUtility;		return cachedOLMUtility;
}		}
Show All 26 Lines	if (
currentDate - lastPrekeyPublishDate >= maxOldPrekeyAge		currentDate - lastPrekeyPublishDate >= maxOldPrekeyAge
) {		) {
account.forget_old_prekey();		account.forget_old_prekey();
}		}
}		}

export {		export {
createPickledOlmAccount,		createPickledOlmAccount,
		createPickledOlmSession,
getOlmUtility,		getOlmUtility,
unpickleOlmAccount,		unpickleOlmAccount,
		unpickleOlmSession,
validateAccountPrekey,		validateAccountPrekey,
};		};

[native] Update native to match new landing SIWE behaviorClosedPublicActions