[native] Prevent nested scroll in the message results screen
ClosedPublic
Actions

Authored by rohan on Jun 20 2023, 11:40 AM.

Details

Reviewers

michal
inka

Commits

rCOMMb3c372c1c03d: [native] Prevent nested scroll in the message results screen

Summary

This is the native counterpart to the previous diff that handled the nested scroll in the message results modal on web. These changes will maintain the scrollable message in the toggle pin modal, but show the message in full when navigating to see the pinned messages or search results.

The changes here also cover the issue where two pinned messages back to back would prevent the user from scrolling to see other messages ENG-4150.

Depends on D8259

Test Plan

Checked the toggle pin modal to confirm messages still scroll, checked both the search results / pinned messages screens to confirm that the messages show in full, and confirm that two long messages won't block scroll now.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 20 2023, 11:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2023, 11:40 AM

rohan edited the summary of this revision. (Show Details)Jun 20 2023, 11:41 AM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F597666: Screen Recording 2023-06-20 at 2.38.35 PM.mov. (Show Details)

Harbormaster completed remote builds in B20362: Diff 27907.Jun 20 2023, 11:57 AM

rohan requested review of this revision.Jun 20 2023, 11:57 AM

Thank you for updating message search as well!

native/chat/message-result.react.js
32 ↗	(On Diff #27907)	Why isn’t this read only?
49–53 ↗	(On Diff #27907)	It seems we usually use this array syntax. You could also extract this style `{overflow: 'scroll',maxHeight: 400}` to unbound styles, since it's not dependent on anything in the runtime, and use ternary operator to make this code shorter (example), but it's up to you.