[native] Add missing punctuation to discard changes alert
ClosedPublic
Actions

Authored by rohan on Jun 21 2023, 9:08 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM0ae4a5478e95: [native] Add missing punctuation to discard changes alert

Summary

Realized I didn't add a period at the end of the discard changes alert text and landed before addressing this feedback.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 21 2023, 9:08 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2023, 9:08 AM

rohan added a reviewer: ginsu.Jun 21 2023, 9:08 AM

rohan published this revision for review.Jun 21 2023, 9:36 AM

atul accepted this revision.Jun 21 2023, 9:47 AM

This revision is now accepted and ready to land.Jun 21 2023, 9:47 AM

Harbormaster completed remote builds in B20401: Diff 27971.Jun 21 2023, 10:09 AM

Closed by commit rCOMM0ae4a5478e95: [native] Add missing punctuation to discard changes alert (authored by rohan). · Explain WhyJun 21 2023, 10:29 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM0ae4a5478e95: [native] Add missing punctuation to discard changes alert.

ashoat mentioned this in D8159: [native] Handle unsaved changes when 'cancel' is pressed.Jun 28 2023, 2:56 PM

Revision Contents
Changeset List

Path

Size

native/

roles/

change-roles-header-left-button.react.js

2 lines

Diff 27972

View Options

native/roles/change-roles-header-left-button.react.js

This file was moved to services/lib/src/DatabaseEntitiesTools.h.

[native] Add missing punctuation to discard changes alertClosedPublicActions