Page MenuHomePhabricator
Differential D8334

[chore] remove unused files and folders
ClosedPublic
Actions

Authored by varun on Jun 27 2023, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 3:11 AM
Unknown Object (File)
Sat, Jun 29, 3:11 AM
Unknown Object (File)
Sat, Jun 29, 3:05 AM
Unknown Object (File)
Sat, Jun 29, 1:47 AM
Unknown Object (File)
Fri, Jun 28, 2:16 PM
Unknown Object (File)
Wed, Jun 26, 2:24 PM
Unknown Object (File)
Fri, Jun 21, 8:05 PM
Unknown Object (File)
Wed, Jun 19, 9:13 PM
View All 41 Files
Subscribers
tomek

Details

Reviewers
atul
• jon
ashoat
Commits
rCOMMe517515ab89c: [chore] remove unused files and folders
Summary

removed comm-opaque and all references to it
removed shared/protos/_generated since we don't use any generated C++ files for gRPC anymore
removed opaque-ke from the identity service since we use comm-opaque2 instead

Test Plan

built keyserver and identity service successfully. will see if CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 27 2023, 8:32 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 8:32 AM
varun added a child revision: D8336: [chore] clean up more services stuff.Jun 27 2023, 8:47 AM
Harbormaster completed remote builds in B20548: Diff 28181.Jun 27 2023, 8:49 AM
varun requested review of this revision.Jun 27 2023, 8:49 AM
atul accepted this revision.Jun 27 2023, 9:08 AM
atul added 2 blocking reviewer(s): • jon, ashoat.

Looks reasonable, would be good to get @jon and @ashoat's sign-off since they have more context on services.

• jon accepted this revision.Jun 27 2023, 9:12 AM
ashoat requested changes to this revision.Jun 27 2023, 9:26 AM
ashoat added 1 blocking reviewer(s): • jon.

Should services/lib/docker/proto_codegen.sh also be deleted? How about any of the other scripts in that folder?

This revision now requires changes to proceed.Jun 27 2023, 9:26 AM
varun requested review of this revision.Jun 27 2023, 9:29 AM
In D8334#245907, @ashoat wrote:

Should services/lib/docker/proto_codegen.sh also be deleted? How about any of the other scripts in that folder?

i remove services/lib in the following diff in the stack

atul accepted this revision.Jun 28 2023, 10:25 AM
ashoat accepted this revision.Jun 28 2023, 6:22 PM
This comment was removed by ashoat.
• jon accepted this revision.Jun 29 2023, 7:15 AM
This revision is now accepted and ready to land.Jun 29 2023, 7:15 AM
Closed by commit rCOMMe517515ab89c: [chore] remove unused files and folders (authored by varun). · Explain WhyJun 29 2023, 8:09 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe517515ab89c: [chore] remove unused files and folders.

Revision Contents
Changeset List

Diff 28268

View Options

keyserver/Dockerfile

Loading...
View Options

keyserver/addons/rust-node-addon/Cargo.lock

Loading...
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Loading...
View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/Dockerfile

Loading...
View Options

services/identity/src/config.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/interceptor.rs

Loading...
View Options

services/identity/src/keygen.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

shared/comm-opaque/.gitignore

Loading...
View Options

shared/comm-opaque/Cargo.lock

Loading...
View Options

shared/comm-opaque/Cargo.toml

Loading...
View Options

shared/comm-opaque/src/lib.rs

Loading...
View Options

shared/comm-opaque/src/opaque.rs

Loading...
View Options

shared/protos/CMakeLists.txt

Loading...
View Options

shared/protos/_generated/.clang-format

Loading...
View Options

shared/protos/_generated/backup.grpc.pb.h

Loading...
View Options

shared/protos/_generated/backup.grpc.pb.cc

Loading...
View Options

shared/protos/_generated/backup.pb.h

Loading...
View Options

shared/protos/_generated/backup.pb.cc

Loading...
View Options

shared/protos/_generated/blob.grpc.pb.h

Loading...
View Options

shared/protos/_generated/blob.grpc.pb.cc

Loading...
View Options

shared/protos/_generated/blob.pb.h

Loading...
View Options

shared/protos/_generated/blob.pb.cc

Loading...