[lib] Add util functions to get blob URI
ClosedPublic
Actions

Authored by bartek on Jun 29 2023, 6:42 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMM5fe29a6cc624: [lib] Add util functions to get blob URI

Summary

Part of ENG-3966.

Introduced simple utility functions that should be used always when we want to get blob URI from encrypted multimedia, instead of accessing blobURI / holder directly.
These functions will be used in the next diff to make this one small and clean

Depends on D8371

Test Plan

This stack is tested altogether, CI will fail at this point due to Flow breaking changes.
Actual test plan in the last diff.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 29 2023, 6:42 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 29 2023, 6:42 AM

bartek added a child revision: D8373: Use dedicated functions to get blobURI.Jun 29 2023, 6:42 AM

Harbormaster failed remote builds in B20609: Diff 28257!Jun 29 2023, 6:52 AM

Fix import

Harbormaster failed remote builds in B20612: Diff 28260!Jun 29 2023, 7:17 AM

bartek edited the summary of this revision. (Show Details)Jun 29 2023, 7:34 AM

bartek published this revision for review.Jun 29 2023, 8:14 AM

It would be easier to review this if you included the first usage in the diff. It helps to be able to see the usage alongside the implementation

Accepting on the assumption that the Flow issues are introduced in the parent diff, but after fixing that you should rebase this diff to make sure that Flow is fixed up

This revision is now accepted and ready to land.Jul 2 2023, 2:13 PM

In D8372#247416, @ashoat wrote:

It would be easier to review this if you included the first usage in the diff. It helps to be able to see the usage alongside the implementation

Perhaps I should have merged this and the D8373 together

Accepting on the assumption that the Flow issues are introduced in the parent diff, but after fixing that you should rebase this diff to make sure that Flow is fixed up

The remaining Flow issues are fixed by the child diff by using the functions introduced here.

Rebase

Harbormaster failed remote builds in B20832: Diff 28519!Jul 10 2023, 2:38 AM

This revision was landed with ongoing or failed builds.Jul 11 2023, 2:58 AM

Closed by commit rCOMM5fe29a6cc624: [lib] Add util functions to get blob URI (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5fe29a6cc624: [lib] Add util functions to get blob URI.