Use dedicated functions to get blobURI
ClosedPublic
Actions

Authored by bartek on Jun 29 2023, 6:42 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMM6f2f3a1ca0b5: Use dedicated functions to get blobURI

Summary

Part of ENG-3966.

In this diff, I use the new utilities from the previous diff to correctly read the blob URI in all places where it's accessed. This ensures compatibility with both old and new message formats.

Depends on D8372

Test Plan

This stack is tested altogether, actual test plan in the last diff.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 29 2023, 6:42 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 29 2023, 6:42 AM

bartek added a child revision: D8374: [lib][keyserver] Use blobURI based on client version.Jun 29 2023, 6:43 AM

Harbormaster failed remote builds in B20610: Diff 28258!Jun 29 2023, 6:53 AM

Fix import

Harbormaster completed remote builds in B20613: Diff 28261.Jun 29 2023, 7:27 AM

bartek edited the summary of this revision. (Show Details)Jun 29 2023, 7:41 AM

bartek published this revision for review.Jun 29 2023, 8:15 AM

bartek edited the test plan for this revision. (Show Details)

bartek added inline comments.

lib/utils/message-ops-utils.js
52 ↗	(On Diff #28261)	Hopefully, when serializing message to `Client DB`, I kept the original `uri` field name, so the format of stored data won't change here
151 ↗	(On Diff #28261)	After deserializing from `Client DB`, we can construct a multimedia message in the new format, it will be understood correctly from now on.

I am accepting this fairly blindly. I don't have a good idea of all the callsites that need to be updated here, or the general data flow. Trusting that @bartek has thought it through and tested it carefully

This revision is now accepted and ready to land.Jul 2 2023, 6:32 PM

In D8373#247421, @ashoat wrote:

I am accepting this fairly blindly. I don't have a good idea of all the callsites that need to be updated here, or the general data flow. Trusting that @bartek has thought it through and tested it carefully

These are all places where we accessed properties holder/thumbnailHolder of objects of types Media and MediaInfo. The types were affected by changes in D8370.