Script downloads SQLite code (if it does not exist) and generates two files:
- CommQueryExecutor.js which is glue code in ES6 format, will be imported to JS code
- CommQueryExecutor.wasm which is actual implementation
Details
Details
- run script and check if files are created properly
- run second time and check if SQLite assets are not re-downloaded
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 98 | each file responsible for adding @generated will also be ignored by phabricator, not sure what will be the best way to fix this | |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 21–23 | version we are using on the web right now but we can consider updating to a newer | |
| 25–33 | inspired by tool we currently using on web (src) | |
| 58–59 | allows using memory managment | |
| 60–62 | we will need to read virtual file with database content to persist, this allows using C++ file system from JS level | |
| 65–70 | this allows importing .js file as regular lib and use with our config | |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 11 | Should this be moved out (eg. to shared/) now that it's no longer native-specific? Fine to handle this later, but feel share a link to a Linear task before landing! | |
| 12 | Given sqlite has a separate license, we should make sure to store it in a file named third-party, and make sure that the LICENSE file is included in that folder An example is the native/cpp/third-party folder | |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 103 ↗ | (On Diff #28412) | purpose is to address https://phab.comm.dev/D8394#inline-53919 |
| 10–13 | right, my bad - thanks for suggestion | |
| 11 | Yeah, good call: ENG-4311 | |
| 12 | Note from 1:1 meeting with @ashoat: SQLite is in the public domain and we not have to include LICENSE | |
| 98 | in that case, should I add a line to remove .js=.bak file? | |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 101 ↗ | (On Diff #28412) | Sorry, i forgot this doesn't follow normal posix conventions. It will take everything immediately after -i |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 101 ↗ | (On Diff #28582) | I am not sure if I follow your idea here but file comm-query-executor.js.bak is still generated, should I add a line in the script to remove it or add it to .gitignore? |
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 101 ↗ | (On Diff #28582) | Unfortunately yes, I think ignoring a file is better than failing whether or not people do nix develop before running this file. |