[native] remove unnecessary async/await in emoji keyboard
ClosedPublic
Actions

Authored by ginsu on Jul 3 2023, 1:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 12:47 PM

	Unknown Object (File)
	Sat, Nov 23, 12:47 PM

	Unknown Object (File)
	Sat, Nov 23, 12:47 PM

	Unknown Object (File)
	Oct 28 2024, 11:02 AM

	Unknown Object (File)
	Oct 3 2024, 1:49 AM

	Unknown Object (File)
	Oct 3 2024, 1:49 AM

	Unknown Object (File)
	Oct 3 2024, 1:48 AM

	Unknown Object (File)
	Oct 3 2024, 1:44 AM

View All 90 Files

Subscribers

ashoat

tomek

Details

Reviewers

kamil
atul

Commits

rCOMM63eac315a98a: [native] remove unnecessary async/await in emoji keyboard

Summary

Small follow up diff to address comments in D8282

Test Plan

confirmed that the recently selected emoji persistence behavior still worked as expected

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jul 3 2023, 1:22 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 3 2023, 1:22 AM

ginsu added reviewers: kamil, atul.Jul 3 2023, 1:23 AM

ginsu mentioned this in D8282: [native] persist recently used emojis.

Harbormaster completed remote builds in B20674: Diff 28332.Jul 3 2023, 1:39 AM

ginsu requested review of this revision.Jul 3 2023, 1:39 AM

kamil accepted this revision.Jul 3 2023, 5:29 AM

This revision is now accepted and ready to land.Jul 3 2023, 5:29 AM

Closed by commit rCOMM63eac315a98a: [native] remove unnecessary async/await in emoji keyboard (authored by ginsu). · Explain WhyJul 5 2023, 1:36 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM63eac315a98a: [native] remove unnecessary async/await in emoji keyboard.

Revision Contents
Changeset List

Path

Size

native/

components/

emoji-keyboard.react.js

8 lines

Diff 28332

View Options

native/components/emoji-keyboard.react.js

[native] remove unnecessary async/await in emoji keyboardClosedPublicActions