Page MenuHomePhabricator
Differential D8409

[native] remove unnecessary async/await in emoji keyboard
ClosedPublic
Actions

Authored by ginsu on Jul 3 2023, 1:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 7:18 AM
Unknown Object (File)
Mar 10 2025, 8:43 AM
Unknown Object (File)
Mar 10 2025, 8:43 AM
Unknown Object (File)
Mar 10 2025, 8:43 AM
Unknown Object (File)
Mar 10 2025, 8:16 AM
Unknown Object (File)
Mar 6 2025, 10:26 PM
Unknown Object (File)
Feb 15 2025, 8:42 AM
Unknown Object (File)
Feb 11 2025, 4:59 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
atul
Commits
rCOMM63eac315a98a: [native] remove unnecessary async/await in emoji keyboard
Summary

Small follow up diff to address comments in D8282

Test Plan

confirmed that the recently selected emoji persistence behavior still worked as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
components/
8 lines

Diff 28332

View Options

native/components/emoji-keyboard.react.js

Show First 20 Lines • Show All 935 Lines • ▼ Show 20 Lines declare export type RouteProp<
ParamList: ParamListBase = ParamListBase, ParamList: ParamListBase = ParamListBase,
RouteName: $Keys<ParamList> = $Keys<ParamList>, RouteName: $Keys<ParamList> = $Keys<ParamList>,
> = {| > = {|
...LeafRoute<RouteName>, ...LeafRoute<RouteName>,
+params: $ElementType<ParamList, RouteName>, +params: $ElementType<ParamList, RouteName>,
+path?: string, +path?: string,
|}; |};
declare type ScreenOptionsProp<
ScreenOptions: {...},
RouteParam,
NavHelpers,
> =
| ScreenOptions
| ({| +route: RouteParam, +navigation: NavHelpers |}) => ScreenOptions;
declare export type ScreenListeners< declare export type ScreenListeners<
State: NavigationState = NavigationState, State: NavigationState = NavigationState,
EventMap: EventMapBase = EventMapCore<State>, EventMap: EventMapBase = EventMapCore<State>,
> = $ObjMapi< > = $ObjMapi<
{| [name: $Keys<EventMap>]: empty |}, {| [name: $Keys<EventMap>]: empty |},
<K: $Keys<EventMap>>(K, empty) => EventListenerCallback<K, State, EventMap>, <K: $Keys<EventMap>>(K, empty) => EventListenerCallback<K, State, EventMap>,
>; >;
declare type ScreenListenersProp<
ScreenListenersParam: {...},
RouteParam,
NavHelpers,
> =
| ScreenListenersParam
| ({| +route: RouteParam, +navigation: NavHelpers |}) => ScreenListenersParam;
declare type BaseScreenProps< declare type BaseScreenProps<
ParamList: ParamListBase, ParamList: ParamListBase,
NavProp, NavProp,
RouteName: $Keys<ParamList> = $Keys<ParamList>, RouteName: $Keys<ParamList> = $Keys<ParamList>,
State: NavigationState = NavigationState, State: NavigationState = NavigationState,
ScreenOptions: {...} = {...}, ScreenOptions: {...} = {...},
EventMap: EventMapBase = EventMapCore<State>, EventMap: EventMapBase = EventMapCore<State>,
> = {| > = {|
+name: RouteName, +name: RouteName,
+options?: +options?: ScreenOptionsProp<
| ScreenOptions ScreenOptions,
| ({| RouteProp<ParamList, RouteName>,
+route: RouteProp<ParamList, RouteName>, NavProp,
+navigation: NavProp, >,
|}) => ScreenOptions, +listeners?: ScreenListenersProp<
+listeners?: ScreenListeners<State, EventMap>,
| ScreenListeners<State, EventMap> RouteProp<ParamList, RouteName>,
| ({| NavProp,
+route: RouteProp<ParamList, RouteName>, >,
+navigation: NavProp,
|}) => ScreenListeners<State, EventMap>,
+initialParams?: $Partial<$ElementType<ParamList, RouteName>>, +initialParams?: $Partial<$ElementType<ParamList, RouteName>>,
+getId?: ({ +getId?: ({
+params: $ElementType<ParamList, RouteName>, +params: $ElementType<ParamList, RouteName>,
}) => string | void, }) => string | void,
+navigationKey?: string, +navigationKey?: string,
|}; |};
declare export type ScreenProps< declare export type ScreenProps<
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines >(props: ScreenProps<
ParamList, ParamList,
NavProp, NavProp,
RouteName, RouteName,
State, State,
ScreenOptions, ScreenOptions,
EventMap, EventMap,
>) => React$Node; >) => React$Node;
declare type ScreenOptionsProp< declare type ScreenOptionsProps<
ScreenOptions: {...}, ScreenOptions: {...},
RouteParam, RouteParam,
NavHelpers, NavHelpers,
> = {| > = {|
+screenOptions?: +screenOptions?: ScreenOptionsProp<ScreenOptions, RouteParam, NavHelpers>,
| ScreenOptions
| ({| +route: RouteParam, +navigation: NavHelpers |}) => ScreenOptions,
|}; |};
declare type ScreenListenersProp< declare type ScreenListenersProps<
ScreenListenersParam: {...}, ScreenListenersParam: {...},
RouteParam, RouteParam,
NavHelpers, NavHelpers,
> = {| > = {|
+screenListeners?: +screenListeners?: ScreenListenersProp<
| ScreenListenersParam ScreenListenersParam,
| ({| RouteParam,
+route: RouteParam, NavHelpers,
+navigation: NavHelpers, >,
|}) => ScreenListenersParam,
|}; |};
declare export type ExtraNavigatorPropsBase = { declare export type ExtraNavigatorPropsBase = {
...$Exact<DefaultRouterOptions>, ...$Exact<DefaultRouterOptions>,
+id?: string, +id?: string,
+children?: React$Node, +children?: React$Node,
... ...
}; };
declare export type NavigatorProps< declare export type NavigatorProps<
ScreenOptions: {...}, ScreenOptions: {...},
ScreenListenersParam, ScreenListenersParam,
RouteParam, RouteParam,
NavHelpers, NavHelpers,
ExtraNavigatorProps: ExtraNavigatorPropsBase, ExtraNavigatorProps: ExtraNavigatorPropsBase,
> = { > = {
...$Exact<ExtraNavigatorProps>, ...$Exact<ExtraNavigatorProps>,
...ScreenOptionsProp<ScreenOptions, RouteParam, NavHelpers>, ...ScreenOptionsProps<ScreenOptions, RouteParam, NavHelpers>,
...ScreenListenersProp<ScreenListenersParam, RouteParam, NavHelpers>, ...ScreenListenersProps<ScreenListenersParam, RouteParam, NavHelpers>,
... ...
}; };
declare export type NavigatorPropsBase< declare export type NavigatorPropsBase<
ScreenOptions: {...}, ScreenOptions: {...},
ScreenListenersParam: {...}, ScreenListenersParam: {...},
NavHelpers, NavHelpers,
> = NavigatorProps< > = NavigatorProps<
ScreenOptions, ScreenOptions,
Show All 27 Lines >() => {|
+Navigator: React$ComponentType<$Exact<NavigatorProps< +Navigator: React$ComponentType<$Exact<NavigatorProps<
ScreenOptions, ScreenOptions,
ScreenListeners<State, EventMap>, ScreenListeners<State, EventMap>,
RouteProp<ParamList>, RouteProp<ParamList>,
NavHelpers, NavHelpers,
ExtraNavigatorProps, ExtraNavigatorProps,
>>>, >>>,
+Group: React$ComponentType<{| +Group: React$ComponentType<{|
...ScreenOptionsProp<ScreenOptions, RouteProp<ParamList>, NavHelpers>, ...ScreenOptionsProps<ScreenOptions, RouteProp<ParamList>, NavHelpers>,
+children: React$Node, +children: React$Node,
+navigationKey?: string, +navigationKey?: string,
|}>, |}>,
|}; |};
declare export type CreateNavigatorFactory = < declare export type CreateNavigatorFactory = <
State: NavigationState, State: NavigationState,
ScreenOptions: {...}, ScreenOptions: {...},
Show All 33 Lines declare export type UseNavigationBuilder = <
Action: GenericNavigationAction, Action: GenericNavigationAction,
ScreenOptions: {...}, ScreenOptions: {...},
RouterOptions: DefaultRouterOptions, RouterOptions: DefaultRouterOptions,
NavHelpers, NavHelpers,
>( >(
routerFactory: RouterFactory<State, Action, RouterOptions>, routerFactory: RouterFactory<State, Action, RouterOptions>,
options: {| options: {|
...$Exact<RouterOptions>, ...$Exact<RouterOptions>,
...ScreenOptionsProp<ScreenOptions, RouteProp<>, NavHelpers>, ...ScreenOptionsProps<ScreenOptions, RouteProp<>, NavHelpers>,
+children?: React$Node, +children?: React$Node,
|}, |},
) => {| ) => {|
+id?: string, +id?: string,
+state: State, +state: State,
+descriptors: {| +[key: string]: Descriptor<NavHelpers, ScreenOptions> |}, +descriptors: {| +[key: string]: Descriptor<NavHelpers, ScreenOptions> |},
+navigation: NavHelpers, +navigation: NavHelpers,
|}; |};
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines